Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): Add span instrumentation for process_transaction_no_celery #79238

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

0Calories
Copy link
Member

We have a new function that process transactions in the Kafka consumer itself instead of starting a celery task, this PR adds some spans some we can get some observability into the performance of this code path

@0Calories 0Calories self-assigned this Oct 16, 2024
@0Calories 0Calories requested a review from a team as a code owner October 16, 2024 21:09
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2024
Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/ingest/consumer/processors.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79238      +/-   ##
==========================================
- Coverage   78.27%   78.27%   -0.01%     
==========================================
  Files        7137     7136       -1     
  Lines      314617   314638      +21     
  Branches    51367    51376       +9     
==========================================
- Hits       246273   246270       -3     
- Misses      61897    61916      +19     
- Partials     6447     6452       +5     

@ghengiskhanh
Copy link

I know sampling may be low. But would it help if we put this in a feature flag in case we need to turn it off?

@0Calories
Copy link
Member Author

@ghengiskhanh these SDK calls are only present in the code path where no_celery_mode is enabled, which is only enabled for s4s at the moment so it's safe. In the worst case I can also revert this PR, so I don't think a feature flag is needed

@0Calories 0Calories merged commit 2fcd539 into master Oct 17, 2024
49 of 50 checks passed
@0Calories 0Calories deleted the ash/feat/instrument-process-transaction branch October 17, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants