Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): Reduce motion on new tabs #79239

Closed
wants to merge 1 commit into from
Closed

ref(ui): Reduce motion on new tabs #79239

wants to merge 1 commit into from
+47 −60

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 16, 2024 21:17
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team October 16, 2024 21:17
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...issueList/groupSearchViewTabs/editableTabTitle.tsx 26.66% 11 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #79239       +/-   ##
===========================================
+ Coverage   64.87%   78.33%   +13.46%     
===========================================
  Files        7123     7123               
  Lines      314392   314392               
  Branches    51344    51344               
===========================================
+ Hits       203948   246279    +42331     
+ Misses     101060    61669    -39391     
+ Partials     9384     6444     -2940

priscilawebdev
priscilawebdev approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. But why are we doing that?

@evanpurkhiser
Copy link
Member Author

Will propose something else in a bit

@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ui-reduce-motion-on-new-tabs branch October 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @priscilawebdev