Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issues): Cleanup group details global styles #79241

Merged
merged 1 commit into from
Oct 16, 2024
+3 −138
Merged

feat(issues): Cleanup group details global styles #79241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/app/views/issueDetails/shortIdBreadcrumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export function ShortIdBreadcrumb({
/>
<ShortIdCopyable>
<Tooltip
className="help-link"
title={t(
'This identifier is unique across your organization, and can be used to reference an issue in various places, like commit messages.'
)}
Expand Down
126 changes: 3 additions & 123 deletions static/less/group-detail.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

.group-detail {
position: relative;
clear: both;

h3 {
font-size: 22px;
Expand All @@ -23,67 +22,22 @@
}

.count {
&.short-id-box {
min-width: 0;

span:not(.help-link) {
font-size: 18px;
line-height: 1.45;
display: block;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
direction: rtl;
}
}

span:not(.help-link) {
font-size: 22px;
display: inline-block;
line-height: 1.2;
}
}

.assigned-to {
text-align: right;
position: relative;
font-size: 22px;
display: inline-block;
line-height: 1.2;
}

.meta {
margin: 0 0 15px;
color: #949ea4;
}

.id-label {
background: #fff;
max-width: 200px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

.severity {
display: inline-block;
position: relative;
top: -7px;
padding: 0 10px;
}

.nav-tabs {
margin-top: 20px;
margin-bottom: 0;
}

&:before {
position: absolute;
display: block;
content: '';
bottom: -1px;
left: -40px;
right: -40px;
height: 1px;
background: @trim;
}
}

/**
Expand All @@ -105,17 +59,6 @@
.primary {
flex: 1;

.user-report {
border-radius: 0;
box-shadow: none;
padding: 20px 30px 0 40px;
border: 0;
border-top: 1px solid lighten(@trim, 4);
margin: 0;

padding-bottom: 0;
}

@media (min-width: 1200px) {
// TODO(dcramer): whatever flex is doing here is causing this to extend to
// whatever it pleases (e.g. 4k pixels on my 1280 screen)
Expand Down Expand Up @@ -420,19 +363,6 @@ div.traceback > ul {
margin: 0 2px;
}

.blame {
color: lighten(@gray, 5);

a {
color: @gray;
}

.icon-mark-github {
position: relative;
top: 1px;
}
}

.tooltip-inner {
word-wrap: break-word;
text-align: left;
Expand Down Expand Up @@ -825,20 +755,6 @@ span.val {
color: @gray-dark;
}
}

.back-to,
.pull-right a {
font-size: 16px;
}

.back-to {
border-left: 1px solid @trim;
padding: 2px 10px;
display: inline-block;
margin-left: 7px;
position: relative;
top: -3px;
}
}
}
}
Expand Down Expand Up @@ -1001,17 +917,6 @@ ul.crumbs {
}
}

/**
* Responsive medium screen
* ============================================================================
*/

@media (max-width: 991px) {
.group-stats-column {
float: none;
}
}

/**
* Responsive small screen
* ============================================================================
Expand Down Expand Up @@ -1066,10 +971,6 @@ ul.crumbs {
}
}

.user-report {
padding: 15px 0;
}

.exception {
margin: 0;
padding: 15px 0;
Expand All @@ -1092,26 +993,5 @@ ul.crumbs {
border: 0;
margin-bottom: 20px;
}

.detailed-error {
border-top: 1px solid @trim;
}
}

// Context callout

.context-summary {
flex-direction: column;
margin-top: 0;
padding: 0;
margin-bottom: 20px;
}

.context {
overflow: auto;

li {
width: 800px;
}
}
}
14 changes: 0 additions & 14 deletions static/less/layout.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,20 +75,6 @@ body.narrow {
color: @gray-dark;
}
}

.back-to,
.pull-right a {
font-size: 16px;
}
Comment on lines -79 to -82
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back-to doesn't seem to exist anywhere


.back-to {
border-left: 1px solid @trim;
padding: 2px 10px;
display: inline-block;
margin-left: 7px;
position: relative;
top: -3px;
}
}

.with-padding {
Expand Down
Loading