test(ui): Add types to test mocks #79255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are currently implicit any which we'd like to turn off. didn't really focus on any area in particular just did a bunch of easy ones. part of getsentry/frontend-tsc#79
github-actions
bot
added
the
Scope: Frontend
saponifi3d
approved these changes
Oct 17, 2024
| let shortIdMock; | ||
| let eventIdMock; | ||
| let configState; | ||
| let orgsMock: jest.Mock; |
There was a problem hiding this comment.
Ideally we provide the type of what it’s mocking I think?
There was a problem hiding this comment.
MockApiClient.addMockResponse return type is jest.Mock<any, any, any> 🤷
| @@ -632,7 +632,7 @@ describe('Discover -> ColumnEditModal', function () { | |||
| }); | |||
|
|
|||
| describe('equation automatic update', function () { | |||
| let onApply; | |||
| let onApply!: jest.Mock; | |||
There was a problem hiding this comment.
Is there any other way that allows us to not use !? 🤔
There was a problem hiding this comment.
we'll need to use it even more if we keep making the types more strict since typescript doesn't know how beforeEach works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are currently implicit any which we'd like to turn off.
didn't really focus on any area in particular just did a bunch of easy ones.
part of getsentry/frontend-tsc#79