Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI Gardening #79258

Merged
merged 3 commits into from
Oct 17, 2024
Merged

ACI Gardening #79258

merged 3 commits into from
Oct 17, 2024

Conversation

saponifi3d
Copy link
Contributor

Description

  • Add none type to the data condition group type - one of the filter mechanisms could include "none of these are true" to evaluate as... true
  • Add to the _init_ files to improve readability for importing from the workfow_enigne
  • Fix the tests in processors/tests_data_source.py because they were super confusing (hijacking the query to fake a result is less good than the pattern established in processors/test_detector.py

@saponifi3d saponifi3d requested a review from a team October 17, 2024 02:54
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 17, 2024
@saponifi3d saponifi3d merged commit 0af2d69 into master Oct 17, 2024
51 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci-random branch October 17, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants