chore(integrations): oauth2 identity pipeline metrics #79325
+143
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Oct 17, 2024
Comment on lines
302
to
+304
| def exchange_token(self, request: Request, pipeline, code): | ||
| # TODO: this needs the auth yet | ||
| data = self.get_token_params(code=code, redirect_uri=absolute_uri(pipeline.redirect_url())) | ||
| verify_ssl = pipeline.config.get("verify_ssl", True) | ||
| try: | ||
| req = safe_urlopen(self.access_token_url, data=data, verify_ssl=verify_ssl) | ||
| body = safe_urlread(req) | ||
| if req.headers.get("Content-Type", "").startswith("application/x-www-form-urlencoded"): | ||
| return dict(parse_qsl(body)) | ||
| return orjson.loads(body) | ||
| except SSLError: | ||
| logger.info( | ||
| "identity.oauth2.ssl-error", | ||
| extra={"url": self.access_token_url, "verify_ssl": verify_ssl}, | ||
| with record_event( | ||
| IntegrationPipelineViewType.TOKEN_EXCHANGE, pipeline.provider.key |
There was a problem hiding this comment.
even though exchange_token is used inside a function that already has a context manager, i decided to emit another lifecycle metric because the errors are more granular inside exchange_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry/src/sentry/identity/__init__.py
Lines 25 to 35 in d7da2a2
These are used in the installation flows for:
Missing:
VSTSOAuth2CallbackViewoverwrites theexchange_tokenfunction (VSTSIdentityProvider,VSTSExtensionIdentityProvider)Not applicable
IdentityProvider)