-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): Add record_meta field to counters consumer #5680
Conversation
This field will be used by the materialized view to determine whether the row should be processed into the meta table.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## master #5680 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 898 898
Lines 43453 43453
Branches 299 299
=======================================
+ Hits 39077 39078 +1
+ Misses 4334 4333 -1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an optimization, would it be better to do it via an allowlist rather than a blacklist? That way we avoid new use cases being recorded in the meta table by default. Something like escalating issues causing unnecessary overhead on the meta table.
I did it this way so that we can avoid a potential step in someone creating a new use case. This way, if a product person creates a new use case, they don't then have to take another step to get auto-complete, it just comes for free. |
This field will be used by the materialized view to determine whether the row
should be processed into the meta table.
Depends on #5681