-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(eap): Clean up the mutations interface #6344
Conversation
* span_id should be a string * _sort_timestamp is no longer directly exposed, instead users provide start_timestamp_ms and it gets converted using the same logic used in the ingestion consumer
Thanks for cleaning this up |
We need to bump the sentry-kafka-schemas in this too, right? |
there is some discussion on getsentry/sentry-kafka-schemas#335 that raises doubts about whether it's better to expose _sort_timestamp or start_timestamp_ms. Right now we require all mutations to be sent with IMO we will probably end up with two kinds of mutations in practice:
For the first group: The other option is that we remove the attribute entirely, and find some other way to fetch this attribute based on some external mapping |
In either of those cases would I expose |
start_timestamp_ms and it gets converted using the same logic used in
the ingestion consumer
This is a follow-up to #6216