Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job-runner): surface job status to snuba admin #6361

Merged
merged 22 commits into from
Oct 3, 2024

Conversation

onewland
Copy link
Contributor

@onewland onewland commented Sep 30, 2024

Connect status tracking to snuba admin

before run:
Screenshot 2024-09-30 at 9 19 45 AM

after run:
Screenshot 2024-09-30 at 9 34 26 AM

Depends on #6332

@onewland onewland requested a review from a team as a code owner September 30, 2024 16:40
Copy link

codecov bot commented Sep 30, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1148 1 1147 3
View the top 1 failed tests by shortest run time
tests.manual_jobs.test_job test_job_status_changes_to_finished
Stack Traces | 0.009s run time
Traceback (most recent call last):
  File ".../tests/manual_jobs/test_job.py", line 42, in test_job_status_changes_to_finished
    assert get_job_status(JOB_ID) is None
AssertionError: assert <JobStatus.NOT_STARTED: 'not_started'> is None
 +  where <JobStatus.NOT_STARTED: 'not_started'> = get_job_status('abc1234')

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Base automatically changed from rachel/status to master October 1, 2024 17:53
@onewland onewland merged commit 52efabf into master Oct 3, 2024
30 checks passed
@onewland onewland deleted the job-runner/surface-status-to-snuba-admin branch October 3, 2024 15:50
Copy link

sentry-io bot commented Oct 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RedisClusterException: No way to dispatch this command to Redis Cluster. Missing key. get_job_specs View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants