RFC: RPCEndpoint standardization #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-sentry
reviewed
Oct 1, 2024
colin-sentry
reviewed
Oct 1, 2024
| from snuba.web.rpc import RPCEndpoint | ||
|
|
||
|
|
||
| class MyRPC(RPCEndpoint[Timestamp, Timestamp]): |
There was a problem hiding this comment.
add a comment or something? unclear what this is for
There was a problem hiding this comment.
this is to test that the registration works?
colin-sentry
reviewed
Oct 1, 2024
| @@ -5,17 +5,17 @@ | |||
| import pytest | |||
| from google.protobuf.timestamp_pb2 import Timestamp | |||
| from sentry_protos.snuba.v1alpha.endpoint_tags_list_pb2 import ( | |||
| TraceItemAttributesRequest, | |||
| TraceItemAttributesRequest as TraceItemAttributesRequestProto, | |||
There was a problem hiding this comment.
is annoying to have to do default imports like this, can we just make sentry-protos name things blahproto by default?
evanh
approved these changes
Oct 2, 2024
| @@ -273,14 +273,11 @@ def unqualified_query_view(*, timer: Timer) -> Union[Response, str, WerkzeugResp | |||
|
|
|||
|
|
|||
| @application.route("/rpc/<name>/<version>", methods=["POST"]) | |||
| @util.time_request("rpc") | |||
There was a problem hiding this comment.
not necessary, the RPC builds in a timer by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This project will need observability, monitoring and other production readiness facets. This PR creates a wrapper around our RPC functionality to allow:
Desired feedback