Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(gocd): Add snuba-eap-mutations consumer to US" #6364

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Sep 30, 2024

Reverts #6359

Consumer isn't rolling out properly for some reason in GoCD and blocking pipeline

@ayirr7 ayirr7 requested a review from a team as a code owner September 30, 2024 23:37
Copy link

codecov bot commented Sep 30, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
682 1 681 1
View the top 1 failed tests by shortest run time
tests.clickhouse.optimize.test_optimize_scheduler test_get_next_schedule[non parallel]
Stack Traces | 0.003s run time
Traceback (most recent call last):
  File ".../clickhouse/optimize/test_optimize_scheduler.py", line 228, in test_get_next_schedule
    assert optimize_scheduler.get_next_schedule(partitions) == expected
AssertionError: assert OptimizationSchedule(partitions_groups=[["(90,'2022-06-27')",\n                                         "(90,'2022-06-20')",\n                                         "(90,'2022-06-13')",\n                                         "(90,'2022-06-08')"]],\n                     cutoff_time=datetime.datetime(2024, 10, 1, 23, 0)) == OptimizationSchedule(partitions_groups=[["(90,'2022-06-27')",\n                                         "(90,'2022-06-20')",\n                                         "(90,'2022-06-13')",\n                                         "(90,'2022-06-08')"]],\n                     cutoff_time=datetime.datetime(2024, 9, 30, 23, 0))
  
  Matching attributes:
  ['partitions_groups']
  Differing attributes:
  ['cutoff_time']
  
  Drill down into differing attribute cutoff_time:
    cutoff_time: datetime.datetime(2024, 10, 1, 23, 0) != datetime.datetime(2024, 9, 30, 23, 0)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@ayirr7 ayirr7 enabled auto-merge (squash) October 1, 2024 00:26
@ayirr7 ayirr7 disabled auto-merge October 1, 2024 00:27
@ayirr7 ayirr7 merged commit 9a5e407 into master Oct 1, 2024
30 checks passed
@ayirr7 ayirr7 deleted the revert-6359-fix/snuba-eap-mutations-us branch October 1, 2024 01:42
untitaker added a commit that referenced this pull request Oct 1, 2024
ayirr7 pushed a commit that referenced this pull request Oct 1, 2024
…6368)

Reverts #6364

In order to roll out #6366 , we need to... deploy the eap consumer

i wish we could just exclude it from our deployment health checks
instead, will check that next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants