Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(deletes): search-issues -> generic-events #6503

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

MeredithAnya
Copy link
Member

@MeredithAnya MeredithAnya commented Nov 4, 2024

Updating for consistency with naming conventions, will need getsentry/sentry-kafka-schemas#347 before we can merge this PR (and update it with the right version)

@MeredithAnya MeredithAnya requested a review from a team as a code owner November 4, 2024 18:22
Copy link

codecov bot commented Nov 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2587 1 2586 5
View the top 1 failed tests by shortest run time
tests.utils.streams.test_topics test_valid_topics
Stack Traces | 0.151s run time
Traceback (most recent call last):
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 79, in get_topic
    with open(topic_path) as f:
         ^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '.../local/lib/python3.11.../sentry_kafka_schemas/topics/snuba-lw-deletions-generic-events.yaml'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../utils/streams/test_topics.py", line 10, in test_valid_topics
    sentry_kafka_schemas.get_topic(
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 82, in get_topic
    raise SchemaNotFound
sentry_kafka_schemas.sentry_kafka_schemas.SchemaNotFound

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@MeredithAnya MeredithAnya enabled auto-merge (squash) November 4, 2024 19:06
@MeredithAnya MeredithAnya merged commit cf25e38 into master Nov 4, 2024
30 checks passed
@MeredithAnya MeredithAnya deleted the meredith/generic-events-delete-topic branch November 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants