Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devservices): Bump devservices to 1.0.16 #185

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

hubertdeng123
Copy link
Member

Picks up quite a few changes, this bumps devservices to latest:
https://github.com/getsentry/devservices/releases/tag/1.0.16

@hubertdeng123 hubertdeng123 requested a review from a team as a code owner February 11, 2025 21:17
@john-z-yang
Copy link
Member

john-z-yang commented Feb 12, 2025

I can't remember what we decided on, but I think there's actually a breaking change here so the reset-kafka recipe in the makefile need to be updated, right?

reset-kafka: install-py-dev ## Reset kafka
	devservices down
	-docker volume rm kafka_kafka-data # I believe this no longer works
	devservices up
.PHONY: reset-kafka

@hubertdeng123
Copy link
Member Author

I can't remember what we decided on, but I think there's actually a breaking change here so the makefile need to be updated, right?

Yep, thought it was added already from before but guess not

@hubertdeng123 hubertdeng123 merged commit d85f672 into main Feb 12, 2025
11 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/bump-devservices-1.0.16 branch February 12, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants