Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): add redirect errors #267

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

JoshFerge
Copy link
Member

note that we can't deploy this untill a corresponding redirect_error has been added to the sentry kafka repo and then the uptime checker, sentry, and snuba have all been bumped with the new version of the library

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should have a test here

@JoshFerge
Copy link
Member Author

lgtm, but we should have a test here

test added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants