Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: catch hyper util errors #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshFerge
Copy link
Member

looking at this https://console.cloud.google.com/logs/query;query=resource.type%3D%22k8s_container%22%0A-jsonPayload.message%3D%22scheduler.tick_scheduled%22%0Alabels.%22k8s-pod%2Fservice%22%3D%22uptime-checker%22%0A-%22DNS%22;summaryFields=:true:32:beginning;cursorTimestamp=2025-02-24T22:52:57.665242903Z;duration=PT15S?project=internal-sentry

we can see there are a lot of raw errors making it through. some of them are these hyper_util errors. we need to pin the library from being a sub-dependency so we can use the error here to cast it and return the parsed error.

it looks like there are some ssl errors which can make it into this category, so can follow up to try to separate those. specifically

check_url.error: reqwest::Error { kind: Request, source: hyper_util::client::legacy::Error(Connect, Ssl(Error { code: ErrorCode(5), cause: None }, X509VerifyResult { code: 0, error: "ok" })) }

@JoshFerge JoshFerge requested a review from a team as a code owner February 24, 2025 22:59
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although we should add a test

@JoshFerge
Copy link
Member Author

lgtm, although we should add a test

will see if i can test this functionality -- have had mixed results trying to replicate to the right connection errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants