Skip to content

Commit

Permalink
ci/package_checks: Add exception for EULA as a package license (#2438)
Browse files Browse the repository at this point in the history
**Summary**

Add an exception for `EULA`, as that is used by the following packages:

```
hsa-amd-aqlprofile
intel-microcode
nvidia-470-glx-driver
nvidia-beta-driver
nvidia-developer-driver
nvidia-glx-driver
opencv
```

This is not a valid SPDX license identifier, but there is no valid
alternative.

Resolves #2423

**Test Plan**

Verify the warning is no longer there:

```
$ ./common/CI/package_checks.py packages/i/intel-microcode/package.yml
Checking files: packages/i/intel-microcode/package.yml
Found 2 result(s), 1 warnings and 0 error(s)
INF packages/i/intel-microcode/package.yml:1: This package is included in the ISO. Consider validating the functionality in a newly built ISO.
WRN packages/i/intel-microcode/package.yml:1: Package release is not incremented by 1
```
  • Loading branch information
ermo authored May 1, 2024
2 parents 93c5658 + 27b56c5 commit b2478b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common/CI/package_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ class SPDXLicense(PullRequestCheck):
_exceptions_url = 'https://raw.githubusercontent.com/spdx/license-list-data/main/json/exceptions.json'
_licenses: Optional[List[str]] = None
_exceptions: Optional[List[str]] = None
_extra_licenses = ['Distributable', 'Public-Domain']
_extra_licenses = ['Distributable', 'EULA', 'Public-Domain']
_error = 'Invalid license identifier: '
_level = Level.WARNING

Expand Down

0 comments on commit b2478b6

Please sign in to comment.