Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cython: update to 3.0.10 #2815

Merged
merged 36 commits into from
Jul 8, 2024
Merged

cython: update to 3.0.10 #2815

merged 36 commits into from
Jul 8, 2024

Conversation

androidnisse
Copy link
Contributor

@androidnisse androidnisse commented Jun 1, 2024 •
edited
Loading

Summary

  • Release notes can be found here.

Test Plan

  • Updated scikit-learn against this.

Checklist

  • Package was built and tested against unstable

Packaging notes

  • Scikit-learn depends on new cython when updated. Therefore I added them in the same pull request.

@ReillyBrogan
Copy link
Contributor

I just checked the release notes for this and there are ~3k commits between the version you're upgrading from and the version you're upgrading too. With that much churn in the code base I'd want to see every single package that has cython as a builddep (it's a compiler, so it's only used during builds) rebuilt as well as part of this PR.

ReillyBrogan
ReillyBrogan previously requested changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@ReillyBrogan ReillyBrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@androidnisse androidnisse marked this pull request as draft June 1, 2024 06:48
@androidnisse
Copy link
Contributor Author

androidnisse commented Jun 1, 2024 •
edited
Loading

Thanks for the feedback @ReillyBrogan I have now rebuilt all the packages, there are some issues in this pull request now as you can see but those are orders of dependencies and a package not bumped. This I will fix.

There were three that did not build, two complaining on cython and one not building whatsoever.

  • python-pyliblo is old and not updated for 9 years.
  • pyyaml is working on cython support for version 3 but it is not supported for now.
  • tensorflow does not build at all.

Arch seems to have solved this problem by having two packages. One legacy for 0.x and one for 3.x I'm not sure what the best way forward from here would be.

@androidnisse androidnisse force-pushed the update_cython branch 3 times, most recently from ad546ea to aa5f8e9 Compare June 1, 2024 16:29
@androidnisse androidnisse requested a review from ReillyBrogan June 2, 2024 12:36
@androidnisse androidnisse force-pushed the update_cython branch 2 times, most recently from 460b7aa to 85b1735 Compare June 5, 2024 10:45
@androidnisse
Copy link
Contributor Author

androidnisse commented Jun 5, 2024 •
edited
Loading

So after my latest comment I have now managed to build all except that old package. So in my opinion it should be looked at if that could be deprecated so it doesn't hold back this stack. What do you say @ReillyBrogan?

Ignore the above. Everything builds now.

@androidnisse androidnisse marked this pull request as ready for review June 5, 2024 13:57
@androidnisse androidnisse force-pushed the update_cython branch 2 times, most recently from f59af27 to e452124 Compare June 5, 2024 15:50
@androidnisse
Copy link
Contributor Author

@ReillyBrogan do you have time to check this? 👍

@androidnisse androidnisse deleted the update_cython branch June 21, 2024 06:26
@androidnisse androidnisse restored the update_cython branch June 21, 2024 06:28
@androidnisse androidnisse reopened this Jun 21, 2024
@androidnisse androidnisse force-pushed the update_cython branch 4 times, most recently from b88b80a to 92fb943 Compare July 3, 2024 15:55
joebonrichie
joebonrichie previously approved these changes Jul 4, 2024
View reviewed changes
@androidnisse androidnisse requested a review from joebonrichie July 8, 2024 07:50
malfisya
malfisya requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@malfisya malfisya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to get this merge soon, but there are few problems:

  • python-h5py is included in python-gssapi commit
  • scikit-learn is included in cython commit
  • printrun is included in numpy commit
  • pyyaml needs a rebuild too

androidnisse added 26 commits July 8, 2024 20:38
@androidnisse @malfisya
python-fonttools: rebuild against cython
840e064 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-gssapi: Rebuild against cython
64f5575 
**Summary**

Rebuild against cython
@androidnisse @malfisya
python-h5py: Rebuild against cython
8611541 
**Summary**

Rebuild against cython
@androidnisse @malfisya
python-lxml: update to 5.2.2
dbb993e 
**Summary**
- The test_feed_parser test could fail if lxml_html_clean was not installed. It is now skipped in that case.
- The minimum CPU architecture for the Linux x86 binary wheels was set back to "core2", without SSE 4.2.
- If libxml2 uses iconv, the compile time version is available as etree.ICONV_COMPILED_VERSION.
@androidnisse @malfisya
python-mistune: rebuild against cython
71c0cd7 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-msgpack: rebuild against cython
d8dfb8e 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-pandas: rebuild against cython
44bc1f8 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-peewee: rebuild against cython
7f719b5 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-pyclipper: update to 1.3.0.5
cf24c51 
**Summary**
- Release notes can be found [here](https://github.com/fonttools/pyclipper/releases).
@androidnisse @malfisya
python-pyproj: rebuild against cython
67e2096 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-pywavelets: rebuild against cython
edcab2a 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-pyzmq: rebuild against cython
d9a93cd 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-rectangle-packer: rebuild against cython
d531102 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-rencode: rebuild against cython
4962644 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-shapely: rebuild against cython
619d66a 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-statsmodels: update to 0.14.2
4f41e08 
**Summary**
 - No release notes for this version.
@androidnisse @malfisya
python-zeroconf: rebuild against cython
17b329e 
**Summary**
- Rebuild against cython.
@androidnisse @malfisya
scikit-image: rebuild against cython
659094c 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
scipy: rebuild against cython
4c0285c 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
spyder3: rebuild against cython
515e3a5 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
vapoursynth: rebuild against cython
62761cd 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
xpra: rebuild against cython
3fc524a 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
zfp: rebuild against cython
a891aae 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
pyyaml: rebuild against cython
f85487f 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
tensorflow: rebuild against cython
a8ed107 
**Summary**
- Rebuild against cython
@androidnisse @malfisya
python-pyliblo: rebuild against cython
ca83cca 
**Summary**
- Rebuild against cython
malfisya
malfisya approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made edits to a few commit messages. Merge time!

@malfisya malfisya merged commit 23e72c8 into getsolus:main Jul 8, 2024
1 check passed
@androidnisse androidnisse deleted the update_cython branch July 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfisya malfisya malfisya approved these changes

@ReillyBrogan ReillyBrogan Awaiting requested review from ReillyBrogan

@joebonrichie joebonrichie Awaiting requested review from joebonrichie

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@androidnisse @ReillyBrogan @joebonrichie @malfisya