Add WebRequest API #7
Conversation
|
@alexstrat, right now the electrons api works well, tested with custom agent header. The cancel callback work also in the dummy extension Lulumi implementation: Chromium: API |
|
Tab console on the left and background console on the right... |
|
@alexstrat ready for a review. I've tried to abstract the RPC but it's not really necessary I think. We will add a lot of lines for the same behaviour. |
lib/common/constants.js
Outdated
| @@ -36,6 +36,8 @@ constants.TABS_SEND_MESSAGE_RESULT_ = 'CHROME_TABS_SEND_MESSAGE_RESULT_'; | |||
| constants.TABS_EXECUTESCRIPT = 'CHROME_TABS_EXECUTESCRIPT'; | |||
| constants.TABS_EXECUTESCRIPT_RESULT_ = 'CHROME_TABS_EXECUTESCRIPT_RESULT_'; | |||
|
|
|||
| constants.TABS_EXECUTESCRIPT_RESULT_ = 'CHROME_TABS_EXECUTESCRIPT_RESULT_'; | |||
| "permissions": [ | ||
| "webRequest", | ||
| "webRequestBlocking", | ||
| "*://*/*", |
There was a problem hiding this comment.
One day we'll need to handle this correctly :) one day
example/main.js
Outdated
| urls: ['<all_urls>'] | ||
| } | ||
|
|
||
| session.defaultSession.webRequest.onResponseStarted(filter, (details) => { |
|
@alexstrat done |
lib/browser/api/web-request.js
Outdated
| const fromChromeObjectToElectronObject = (details) => { | ||
| if (details.responseHeaders) { | ||
| const responseHeaders = []; | ||
| Object.keys(details.responseHeaders).forEach((k) => { |
lib/browser/api/web-request.js
Outdated
| if (cbReturn && cbReturn.responseHeaders) { | ||
| const responseHeaders = {}; | ||
| cbReturn.responseHeaders.forEach((header) => { | ||
| return responseHeaders[header.name] = [header.value] |
| } | ||
|
|
||
| removeListener (callback) { | ||
| const digest = callbackToDigest(callback); |
There was a problem hiding this comment.
Still not sure why you need a callbackToDigest
This could not work here👇: const index = this.listeners.findIndex(cb => cb === callback); ?
| this.rpcManager = new RpcIpcManager(lib, this.rpcScopeRenderer); | ||
| } | ||
|
|
||
| handlerBehaviorChanged () { |
There was a problem hiding this comment.
Let's now ddd a console.warning when dummy-mock methods
lib/browser/api/web-request.js
Outdated
| 'onHeadersReceived', 'onAuthRequired', 'onResponseStarted', 'onBeforeRedirect', 'onCompleted', | ||
| 'onErrorOccurred']; | ||
|
|
||
| const fromElectronObjectToChromeObject = (cbReturn) => { |
There was a problem hiding this comment.
Minor: to be clear, I guess you can reduce the scope of this utility to only headers and rename it more precisely
…o fix/mixmax # Conflicts: # lib/browser/api/web-request.js
| } | ||
| } | ||
|
|
||
| module.exports = ChromeWebRequestAPIHandler; |
lib/browser/rc-event-controller.js
Outdated
| this.controlerRPCScope = `${eventId}-controller`; | ||
| this.eventRPCScope = `${eventId}-event`; | ||
|
|
||
| this.rcpManager = new RpcIpcManager({ |
lib/renderer/extensions/rc-event.js
Outdated
| try { | ||
| return listener.call(this, args); | ||
| } catch (e) { | ||
| return e |
There was a problem hiding this comment.
Rather console.error and return nothing, otherwise it'll try to pass it into callback on main's side
There was a problem hiding this comment.
unless electron-simple-rpc is smart enough to recognize it's an error.
However we don't care
|
One last non minor change and we're good to go ;) |
Todo
removeListenerhasListener