Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Ghost #2178

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

App Submission: Ghost #2178

wants to merge 28 commits into from

Conversation

dennysubke
Copy link
Contributor

App Submission

Ghost

...

Icon

logo

...

Gallery images

a

b

c

d

e

f

g

...

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

@dennysubke
Copy link
Contributor Author

Ghost is f**king awesome! This should definitely be merged. 🚀🔥

Copy link
Contributor

@al-lac al-lac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great submission @dennysubke!

Added some minor changes that should be made.

Really looking forward to having Ghost on the store! 🚀 👻

@nmfretz after the changes this should be good to go.

ghost/docker-compose.yml Outdated Show resolved Hide resolved
ghost/docker-compose.yml Outdated Show resolved Hide resolved
ghost/umbrel-app.yml Outdated Show resolved Hide resolved
ghost/docker-compose.yml Outdated Show resolved Hide resolved
ghost/docker-compose.yml Outdated Show resolved Hide resolved
Copy link

⚠️   Linting finished with 1 warning   ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
⚠️ ghost/umbrel-app.yml "icon" and "gallery" needs to be empty for new app submissions:
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@dennysubke
Copy link
Contributor Author

Really great submission @dennysubke!

Added some minor changes that should be made.

Really looking forward to having Ghost on the store! 🚀 👻

@nmfretz after the changes this should be good to go.

I've made the requested changes - thanks for the review and feedback. 👍

Excited to see Ghost getting merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants