Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paired tumor normal calling #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Paired tumor normal calling #5

wants to merge 5 commits into from

Conversation

caalo
Copy link
Collaborator

@caalo caalo commented Mar 12, 2024

  • Added parameter_meta
  • Reduced the number of private variables for MarkDuplicates
  • Removed old comments

@caalo
Copy link
Collaborator Author

caalo commented Apr 2, 2024

Our final version is paired tumor normal calling: tumor1-normal1, tumor2-normal2 calling.

@caalo caalo changed the title Chris' edits Paired tumor normal calling Apr 2, 2024
Copy link
Collaborator

@sitapriyamoorthi sitapriyamoorthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for change

@@ -1,6 +1,8 @@
{
"mutation_calling.tumorFastq": ["/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/HCC4006_final.fastq", "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/CALU1_combined_final.fastq"],
"mutation_calling.normalFastq": "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/MOLM13_combined_final.fastq",
"mutation_calling.samples": [{"tumorSample": "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/HCC4006_final.fastq",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided that the path will be required to be put in by the reader?
Maybe for testing we can keep this but for the final one we maybe want to say something like /path/to/tumor/1/fastq or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the Fred Hutch json! There's a separate one for non-Fred Hutch (although there is still FH paths in it). I think you created these files so you can make any changes to them if you desire!

mutation_calling.wdl Outdated Show resolved Hide resolved
mutation_calling.wdl Show resolved Hide resolved

# Align fastq file to the reference genome
task BwaMem {
input {
File input_fastq
referenceGenome refGenome
Int threads = 16
}

String base_file_name = basename(input_fastq, ".fastq")
String ref_fasta_local = basename(refGenome.ref_fasta)

String read_group_id = "ID:" + base_file_name
String sample_name = "SM:" + base_file_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had put SM but we can change to anything

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Feel free to make any commits to change that

}

String base_file_name = basename(input_fastq, ".fastq")
String ref_fasta_local = basename(refGenome.ref_fasta)

String read_group_id = "ID:" + base_file_name
String sample_name = "SM:" + base_file_name
String platform = "illumina"
String platform_info = "PL:" + platform # Create the platform information
String platform_info = "PL:illumina"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept that platform variable so that people can add as they please? But i guess for this guide it is okay to expect illumina.

mutation_calling.wdl Outdated Show resolved Hide resolved
mutation_calling.wdl Outdated Show resolved Hide resolved
mutation_calling.wdl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants