Merge pull request #257 from getyoti/release/3.14.0

Release 3.14.0
getyoti · Jan 8, 2021 · 03babf5 · 03babf5
2 parents fb1eabd + 3a665f6
commit 03babf5
Show file tree

Hide file tree

Showing 10 changed files with 86 additions and 18 deletions.
diff --git a/examples/doc-scan/index.js b/examples/doc-scan/index.js
@@ -27,6 +27,7 @@ router.get('/', controllers.indexController);
 router.get('/success', controllers.successController);
 router.get('/media', controllers.mediaController);
 router.get('/error', controllers.errorController);
+router.get('/privacy-policy', async (req, res) => res.render('pages/privacy-policy'));
 
 app.use('/', router);
 

diff --git a/examples/doc-scan/src/controllers/index.controller.js b/examples/doc-scan/src/controllers/index.controller.js
@@ -69,6 +69,7 @@ async function createSession() {
         .withPresetIssuingCountry('GBR')
         .withSuccessUrl(`${config.YOTI_APP_BASE_URL}/success`)
         .withErrorUrl(`${config.YOTI_APP_BASE_URL}/error`)
+        .withPrivacyPolicyUrl(`${config.YOTI_APP_BASE_URL}/privacy-policy`)
         .build()
     )
     .withRequiredDocument(

diff --git a/examples/doc-scan/views/pages/privacy-policy.ejs b/examples/doc-scan/views/pages/privacy-policy.ejs
@@ -0,0 +1,10 @@
+<%- include('layout/header'); -%>
+<div class="container">
+    <div class="row pt-4">
+        <div class="col">
+            <h1>Privacy Policy</h1>
+            <p>Demo Privacy Policy</p>
+        </div>
+    </div>
+</div>
+<%- include('layout/footer'); -%>
diff --git a/examples/doc-scan/views/pages/success.ejs b/examples/doc-scan/views/pages/success.ejs
@@ -502,11 +502,9 @@
                 <div class="card">
                     <div class="card-header" id="sup-doc-file-<%= supDocNum %>">
                         <h4 class="mb-0">
-                            <button class="btn btn-link" type="button">
-                                <a href="/media?mediaId=<%= document.getDocumentFile().getMedia().getId() %>">
+                            <a class="btn btn-link" type="button" href="/media?mediaId=<%= document.getDocumentFile().getMedia().getId() %>">
                                 Download File
-                                </a>
-                            </button>
+                            </a>
                         </h4>
                     </div>
                 </div>
@@ -633,4 +631,4 @@
 
     <% } %>
 </div>
-<%- include('layout/footer'); -%>
+<%- include('layout/footer'); -%>
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yoti",
-  "version": "3.13.1",
+  "version": "3.14.0",
   "description": "Yoti NodeJS SDK for back-end integration",
   "author": "Yoti LTD <[email protected]> (https://www.yoti.com/developers)",
   "license": "MIT",

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -3,7 +3,7 @@ sonar.organization = getyoti
 
 sonar.projectKey = getyoti:node
 sonar.projectName = Node SDK
-sonar.projectVersion = 3.13.1
+sonar.projectVersion = 3.14.0
 sonar.exclusions=tests/**,examples/**,node_modules/**,coverage/**
 sonar.javascript.lcov.reportPaths=coverage/lcov.info
 sonar.verbose = true

diff --git a/src/doc_scan_service/session/create/sdk.config.builder.js b/src/doc_scan_service/session/create/sdk.config.builder.js
@@ -138,6 +138,19 @@ class SdkConfigBuilder {
     return this;
   }
 
+  /**
+   * Sets the privacy policy URL
+   *
+   * @param {string} privacyPolicyUrl the privacy policy URL
+   *
+   * @returns {this}
+   */
+  withPrivacyPolicyUrl(privacyPolicyUrl) {
+    Validation.isString(privacyPolicyUrl, 'privacyPolicyUrl');
+    this.privacyPolicyUrl = privacyPolicyUrl;
+    return this;
+  }
+
   /**
    * Builds the {@link SdkConfig} using the values supplied to the builder
    *
@@ -152,7 +165,8 @@ class SdkConfigBuilder {
       this.locale,
       this.presetIssuingCountry,
       this.successUrl,
-      this.errorUrl
+      this.errorUrl,
+      this.privacyPolicyUrl
     );
   }
 }

diff --git a/src/doc_scan_service/session/create/sdk.config.js b/src/doc_scan_service/session/create/sdk.config.js
@@ -20,6 +20,8 @@ class SdkConfig {
    *   The success URL
    * @param {string} errorUrl
    *   The error URL
+   * @param {string} privacyPolicyUrl
+   *   The privacy policy URL
    */
   constructor(
     allowedCaptureMethods,
@@ -29,7 +31,8 @@ class SdkConfig {
     locale,
     presetIssuingCountry,
     successUrl,
-    errorUrl
+    errorUrl,
+    privacyPolicyUrl
   ) {
     Validation.isString(allowedCaptureMethods, 'allowedCaptureMethods', true);
     this.allowedCaptureMethods = allowedCaptureMethods;
@@ -54,6 +57,9 @@ class SdkConfig {
 
     Validation.isString(errorUrl, 'errorUrl', true);
     this.errorUrl = errorUrl;
+
+    Validation.isString(privacyPolicyUrl, 'privacyPolicyUrl', true);
+    this.privacyPolicyUrl = privacyPolicyUrl;
   }
 
   /**
@@ -69,6 +75,7 @@ class SdkConfig {
       preset_issuing_country: this.presetIssuingCountry,
       success_url: this.successUrl,
       error_url: this.errorUrl,
+      privacy_policy_url: this.privacyPolicyUrl,
     };
   }
 }

diff --git a/tests/doc_scan_service/session/create/sdk.config.builder.test.js b/tests/doc_scan_service/session/create/sdk.config.builder.test.js
@@ -13,6 +13,7 @@ describe('SdkConfigBuilder', () => {
       .withSuccessUrl('some-success-url')
       .withLocale('some-url')
       .withPresetIssuingCountry('some-country')
+      .withPrivacyPolicyUrl('some-privacy-policy-url')
       .build();
 
     const expectedJson = JSON.stringify({
@@ -24,6 +25,7 @@ describe('SdkConfigBuilder', () => {
       preset_issuing_country: 'some-country',
       success_url: 'some-success-url',
       error_url: 'some-error-url',
+      privacy_policy_url: 'some-privacy-policy-url',
     });
 
     expect(JSON.stringify(sdkConfig)).toBe(expectedJson);