Skip to content

Commit

Permalink
SDK-1857 fix GitHub actions coverage (#262)
Browse files Browse the repository at this point in the history
Removed the workflow 'sonar', added sonarcloud as last step of the 'tests' workflow's job (Unit Tests)
  • Loading branch information
laurent-yoti authored Jan 25, 2021
1 parent 9832fd5 commit b534500
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 25 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/sonar.yaml

This file was deleted.

12 changes: 10 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ jobs:
steps:
- uses: actions/checkout@v2
with:
# Disabling shallow clone is recommended for improving relevancy of reporting for sonarcloud
fetch-depth: 0

- uses: actions/[email protected]

Expand All @@ -24,7 +27,13 @@ jobs:

- run: npm test

- run: npm run lint
- name: Fix code coverage paths
run: sed -i 's/\/home\/runner\/work\/yoti-node-sdk\/yoti-node-sdk\//\/github\/workspace\//g' ./coverage/lcov.info

- uses: sonarsource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

examples:
name: Lint Examples
Expand Down Expand Up @@ -97,4 +106,3 @@ jobs:
- run: npm update

- run: npm run unit-test

0 comments on commit b534500

Please sign in to comment.