Merge pull request #248 from getyoti/release/3.13.1

Release 3.13.1

examples/doc-scan/src/controllers/index.controller.js

@@ -81,13 +81,7 @@ async function createSession() {
         .build()
     )
     .withRequiredDocument(
-      (new RequiredIdDocumentBuilder())
-        .withFilter(
-          (new OrthogonalRestrictionsFilterBuilder())
-            .withWhitelistedDocumentTypes(['DRIVING_LICENCE'])
-            .build()
-        )
-        .build()
+      (new RequiredIdDocumentBuilder()).build()
     )
     .withRequiredDocument(
       (new RequiredSupplementaryDocumentBuilder())

examples/doc-scan/src/controllers/media.controller.js

@@ -16,8 +16,14 @@ module.exports = async (req, res) => {
       req.query.mediaId
     );
 
-    res.set('Content-Type', media.getMimeType());
-    res.status(200).end(media.getContent().toBuffer());
+    const { buffer } = media.getContent();
+
+    if (buffer.length === 0) {
+      res.status(204).end(buffer);
+    } else {
+      res.set('Content-Type', media.getMimeType());
+      res.status(200).end(buffer);
+    }
   } catch (error) {
     res.render('pages/error', { error });
   }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "yoti",
-  "version": "3.13.0",
+  "version": "3.13.1",
   "description": "Yoti NodeJS SDK for back-end integration",
   "author": "Yoti LTD <[email protected]> (https://www.yoti.com/developers)",
   "license": "MIT",

sonar-project.properties

@@ -3,8 +3,8 @@ sonar.organization = getyoti
 
 sonar.projectKey = getyoti:node
 sonar.projectName = Node SDK
-sonar.projectVersion = 3.13.0
+sonar.projectVersion = 3.13.1
 sonar.exclusions=tests/**,examples/**,node_modules/**,coverage/**
 sonar.javascript.lcov.reportPaths=coverage/lcov.info
 sonar.verbose = true
-sonar.cpd.exclusions=**/supplementary.document.resource.response.js
+sonar.cpd.exclusions=**/supplementary.document.resource.response.js

src/doc_scan_service/doc.scan.service.js

@@ -158,7 +158,7 @@ class DocScanService {
         .then((response) => {
           try {
             const contentType = response.getHeaders()['content-type'];
-            const mimeType = contentType ? contentType.split(';')[0] : null;
+            const mimeType = contentType ? contentType.split(';')[0] : '';
 
             let content = response.getBody();
             if (!Buffer.isBuffer(content)) {

tests/doc_scan_service/doc.scan.service.spec.js

@@ -299,16 +299,18 @@ describe('DocScanService', () => {
       });
     });
 
-    describe('when content type is not available', () => {
-      it('should reject', (done) => {
+    describe('when response has no content', () => {
+      it('should return empty media', (done) => {
         nock(config.yoti.docScanApi)
           .get(MEDIA_URI)
-          .reply(200, '');
+          .reply(204, '');
 
         docScanService
           .getMediaContent(SESSION_ID, MEDIA_ID)
-          .catch((err) => {
-            expect(err.message).toBe('mimeType must be a string');
+          .then((result) => {
+            expect(result).toBeInstanceOf(Media);
+            expect(result.getContent().buffer).toHaveLength(0);
+            expect(result.getMimeType()).toBe('');
             done();
           })
           .catch(done);