Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vision camera 4 compatibility #17

Closed

Conversation

404-html
Copy link

@404-html 404-html commented May 18, 2024

#14
Android 🆗
iOS 🆗

It's up to library author if he want's create new repo or push that to existing one.

@404-html 404-html marked this pull request as ready for review May 19, 2024 09:47
@gev2002
Copy link
Owner

gev2002 commented May 21, 2024

Hey, Thank you for supporting, but this is plugin for Vision Camera V3 Not form V4.

@gev2002 gev2002 closed this May 21, 2024
@gev2002
Copy link
Owner

gev2002 commented May 21, 2024

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

@404-html
Copy link
Author

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

Thanks, I am happy to contribute.

@beatlecz
Copy link

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

@404-html
Copy link
Author

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

@beatlecz as a temporary workaround you can use use my branch, which works with vision camera v4. In package.json:

"react-native-vision-camera-v3-text-recognition": "github:404-html/react-native-vision-camera-v3-text-recognition#chore/vision-camera-4-compatibility",

@gev2002
Copy link
Owner

gev2002 commented May 23, 2024

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

Hi there, If you want to I speed up and releasing V4 plugin You can sponsor me.For communication, and sponsoring you can write me to gmail [email protected]

@beatlecz
Copy link

beatlecz commented May 23, 2024

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

@beatlecz as a temporary workaround you can use use my branch, which works with vision camera v4. In package.json:

"react-native-vision-camera-v3-text-recognition": "github:404-html/react-native-vision-camera-v3-text-recognition#chore/vision-camera-4-compatibility",

Thx. But I have tried to install the package from github branch with this error result:

npm ERR! code 1
npm ERR! git dep preparation failed
npm ERR! command /Users/mirek/.nvm/versions/node/v18.17.1/bin/node /Users/mirek/.nvm/versions/node/v18.17.1/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/Users/mirek/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! > [email protected] prepare
npm ERR! > bob build
npm ERR! 
npm ERR! ℹ Building target commonjs
npm ERR! ℹ Cleaning up previous build at lib/commonjs
npm ERR! ℹ Compiling 3 files in src with babel
npm ERR! ✔ Wrote files to lib/commonjs
npm ERR! ℹ Building target module
npm ERR! ℹ Cleaning up previous build at lib/module
npm ERR! ℹ Compiling 3 files in src with babel
npm ERR! ✔ Wrote files to lib/module
npm ERR! ℹ Building target typescript
npm ERR! ℹ Cleaning up previous build at lib/typescript
npm ERR! ℹ Generating type definitions with tsc
npm ERR! src/index.tsx:7:10 - error TS2724: '"react-native-worklets-core"' has no exported member named 'useRunInJS'. Did you mean 'useRunOnJS'?
npm ERR! 
npm ERR! 7 import { useRunInJS } from 'react-native-worklets-core';
npm ERR!            ~~~~~~~~~~
npm ERR! 
npm ERR!   node_modules/react-native-worklets-core/lib/typescript/hooks/useRunOnJS.d.ts:20:25
npm ERR!     20 export declare function useRunOnJS<T extends (...args: any[]) => any>(callback: T, dependencyList: DependencyList): (...args: Parameters<T>) => Promise<ReturnType<T>>;
npm ERR!                                ~~~~~~~~~~
npm ERR!     'useRunOnJS' is declared here.
npm ERR! 
npm ERR! src/types.ts:3:3 - error TS2724: '"react-native-vision-camera"' has no exported member named 'FrameProcessor'. Did you mean 'useFrameProcessor'?
npm ERR! 
npm ERR! 3   FrameProcessor,
npm ERR!     ~~~~~~~~~~~~~~
npm ERR! 
npm ERR!   node_modules/react-native-vision-camera/lib/typescript/hooks/useFrameProcessor.d.ts:33:25
npm ERR!     33 export declare function useFrameProcessor(frameProcessor: (frame: Frame) => void, dependencies: DependencyList): ReadonlyFrameProcessor;
npm ERR!                                ~~~~~~~~~~~~~~~~~
npm ERR!     'useFrameProcessor' is declared here.
npm ERR! 
npm ERR! 
npm ERR! Found 2 errors in 2 files.
npm ERR! 
npm ERR! Errors  Files
npm ERR!      1  src/index.tsx:7
npm ERR!      1  src/types.ts:3
npm ERR! ✖ Failed to build definition files.
npm ERR! npm WARN using --force Recommended protections disabled.

@gev2002
Copy link
Owner

gev2002 commented May 23, 2024

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

@beatlecz as a temporary workaround you can use use my branch, which works with vision camera v4. In package.json:

"react-native-vision-camera-v3-text-recognition": "github:404-html/react-native-vision-camera-v3-text-recognition#chore/vision-camera-4-compatibility",

Thx. But I have tried to install the package from github branch with this error result:

npm ERR! code 1
npm ERR! git dep preparation failed
npm ERR! command /Users/mirek/.nvm/versions/node/v18.17.1/bin/node /Users/mirek/.nvm/versions/node/v18.17.1/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/Users/mirek/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! > [email protected] prepare
npm ERR! > bob build
npm ERR! 
npm ERR! ℹ Building target commonjs
npm ERR! ℹ Cleaning up previous build at lib/commonjs
npm ERR! ℹ Compiling 3 files in src with babel
npm ERR! ✔ Wrote files to lib/commonjs
npm ERR! ℹ Building target module
npm ERR! ℹ Cleaning up previous build at lib/module
npm ERR! ℹ Compiling 3 files in src with babel
npm ERR! ✔ Wrote files to lib/module
npm ERR! ℹ Building target typescript
npm ERR! ℹ Cleaning up previous build at lib/typescript
npm ERR! ℹ Generating type definitions with tsc
npm ERR! src/index.tsx:7:10 - error TS2724: '"react-native-worklets-core"' has no exported member named 'useRunInJS'. Did you mean 'useRunOnJS'?
npm ERR! 
npm ERR! 7 import { useRunInJS } from 'react-native-worklets-core';
npm ERR!            ~~~~~~~~~~
npm ERR! 
npm ERR!   node_modules/react-native-worklets-core/lib/typescript/hooks/useRunOnJS.d.ts:20:25
npm ERR!     20 export declare function useRunOnJS<T extends (...args: any[]) => any>(callback: T, dependencyList: DependencyList): (...args: Parameters<T>) => Promise<ReturnType<T>>;
npm ERR!                                ~~~~~~~~~~
npm ERR!     'useRunOnJS' is declared here.
npm ERR! 
npm ERR! src/types.ts:3:3 - error TS2724: '"react-native-vision-camera"' has no exported member named 'FrameProcessor'. Did you mean 'useFrameProcessor'?
npm ERR! 
npm ERR! 3   FrameProcessor,
npm ERR!     ~~~~~~~~~~~~~~
npm ERR! 
npm ERR!   node_modules/react-native-vision-camera/lib/typescript/hooks/useFrameProcessor.d.ts:33:25
npm ERR!     33 export declare function useFrameProcessor(frameProcessor: (frame: Frame) => void, dependencies: DependencyList): ReadonlyFrameProcessor;
npm ERR!                                ~~~~~~~~~~~~~~~~~
npm ERR!     'useFrameProcessor' is declared here.
npm ERR! 
npm ERR! 
npm ERR! Found 2 errors in 2 files.
npm ERR! 
npm ERR! Errors  Files
npm ERR!      1  src/index.tsx:7
npm ERR!      1  src/types.ts:3
npm ERR! ✖ Failed to build definition files.
npm ERR! npm WARN using --force Recommended protections disabled.

This error means that useRunInJs does not exist in work modules, now it is useRunOnJs, you can pay me and I will speed up the creation of a new package and help fix further errors.

@404-html
Copy link
Author

404-html commented May 23, 2024

@beatlecz make sure you are using react-native-worklets-core v 1.3.3, as stated here.

@beatlecz
Copy link

@beatlecz make sure you are using react-native-worklets-core v 1.3.3, as stated here.

Yes I have 1.3.3 of worklets. I have tried to delete node_modules and install again 🤔 without success.

@beatlecz
Copy link

I'll create new repo and update logic for plugin for more performance.I'll happy to see you in new repo.

We are really looking forward for new repo. We have an app in development, and expo sdk 50 supports only vision camera v4 ... We are able to pay you to speed up the creating and releasing v4 plugin.

@beatlecz as a temporary workaround you can use use my branch, which works with vision camera v4. In package.json:

"react-native-vision-camera-v3-text-recognition": "github:404-html/react-native-vision-camera-v3-text-recognition#chore/vision-camera-4-compatibility",

Thx. But I have tried to install the package from github branch with this error result:

npm ERR! code 1

npm ERR! git dep preparation failed

npm ERR! command /Users/mirek/.nvm/versions/node/v18.17.1/bin/node /Users/mirek/.nvm/versions/node/v18.17.1/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/Users/mirek/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run

npm ERR! > [email protected] prepare

npm ERR! > bob build

npm ERR!

npm ERR! ℹ Building target commonjs

npm ERR! ℹ Cleaning up previous build at lib/commonjs

npm ERR! ℹ Compiling 3 files in src with babel

npm ERR! ✔ Wrote files to lib/commonjs

npm ERR! ℹ Building target module

npm ERR! ℹ Cleaning up previous build at lib/module

npm ERR! ℹ Compiling 3 files in src with babel

npm ERR! ✔ Wrote files to lib/module

npm ERR! ℹ Building target typescript

npm ERR! ℹ Cleaning up previous build at lib/typescript

npm ERR! ℹ Generating type definitions with tsc

npm ERR! src/index.tsx:7:10 - error TS2724: '"react-native-worklets-core"' has no exported member named 'useRunInJS'. Did you mean 'useRunOnJS'?

npm ERR!

npm ERR! 7 import { useRunInJS } from 'react-native-worklets-core';

npm ERR! ~~~~~~~~~~

npm ERR!

npm ERR! node_modules/react-native-worklets-core/lib/typescript/hooks/useRunOnJS.d.ts:20:25

npm ERR! 20 export declare function useRunOnJS<T extends (...args: any[]) => any>(callback: T, dependencyList: DependencyList): (...args: Parameters) => Promise<ReturnType>;

npm ERR! ~~~~~~~~~~

npm ERR! 'useRunOnJS' is declared here.

npm ERR!

npm ERR! src/types.ts:3:3 - error TS2724: '"react-native-vision-camera"' has no exported member named 'FrameProcessor'. Did you mean 'useFrameProcessor'?

npm ERR!

npm ERR! 3 FrameProcessor,

npm ERR! ~~~~~~~~~~~~~~

npm ERR!

npm ERR! node_modules/react-native-vision-camera/lib/typescript/hooks/useFrameProcessor.d.ts:33:25

npm ERR! 33 export declare function useFrameProcessor(frameProcessor: (frame: Frame) => void, dependencies: DependencyList): ReadonlyFrameProcessor;

npm ERR! ~~~~~~~~~~~~~~~~~

npm ERR! 'useFrameProcessor' is declared here.

npm ERR!

npm ERR!

npm ERR! Found 2 errors in 2 files.

npm ERR!

npm ERR! Errors Files

npm ERR! 1 src/index.tsx:7

npm ERR! 1 src/types.ts:3

npm ERR! ✖ Failed to build definition files.

npm ERR! npm WARN using --force Recommended protections disabled.

This error means that useRunInJs does not exist in work modules, now it is useRunOnJs, you can pay me and I will speed up the creation of a new package and help fix further errors.

Give me email contact. We can make a deal 😎

@gev2002
Copy link
Owner

gev2002 commented May 24, 2024

@beatlecz This is my email address, you can contact me there [email protected].

@gev2002
Copy link
Owner

gev2002 commented May 27, 2024

The plugin is available now.You can use it https://github.com/gev2002/react-native-vision-camera-text-recognition
By Supporting @beatlecz. 🥳🥳🥳🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants