Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Member Decorations #38

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Conversation

kvark
Copy link
Member

@kvark kvark commented Jul 15, 2019

Part of #5
Refines the decoration support with:

  1. associating member decorations directly with the members
  2. supporting multiple decorations

@kvark kvark requested a review from antiagainst July 15, 2019 03:39
@gfx-rs gfx-rs deleted a comment from googlebot Jul 15, 2019
@antiagainst
Copy link
Collaborator

This one needs a rebase now. :)

@kvark
Copy link
Member Author

kvark commented Jul 16, 2019

Rebased now

Copy link
Collaborator

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used BTreeSet initially to address the issue of potentially duplicated decorations. But I think that can be done with a pass if necessary. Using Vec should be more efficient. Nice! Thanks!

@antiagainst antiagainst merged commit 1852588 into gfx-rs:master Jul 19, 2019
@kvark kvark deleted the decoration branch July 19, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants