Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuda : only use native when supported by cmake #10389

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Nov 18, 2024

cmake only supports CUDA_ARCHITECTURES native in version 3.24
https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html

Fixes #10388

@github-actions github-actions bot added the Nvidia GPU Issues specific to Nvidia GPUs label Nov 18, 2024
@JohannesGaessler
Copy link
Collaborator

Then this is probably also why the docker container builds were failing, I thought the reason was that no GPUs were connected.
(But we should probably still use GGML_NATIVE=OFF for Docker.)

@slaren slaren merged commit d3481e6 into master Nov 18, 2024
55 checks passed
@slaren slaren deleted the sl/fix-cmake-native-version branch November 18, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nvidia GPU Issues specific to Nvidia GPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants