Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dr_wav.h to newer version to fix _MSC_VER macro issues #2449

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

RahulVadhyar
Copy link
Contributor

While using this repo in my project, I have encountered compiling issues with dr_wav.h. Specifically on linux, I have been getting undefined _MSC_VER issues. This has been fixed in the latest versions of dr_wav.h. Hence this PR updates this file to fix the issue.

@ggerganov
Copy link
Owner

Thanks, could you point me to the reference file so I can verify that it matches?

@RahulVadhyar
Copy link
Contributor Author

Thanks, could you point me to the reference file so I can verify that it matches?

Sure, here is the link to the file:

https://github.com/mackron/dr_libs/blob/master/dr_wav.h

@ggerganov ggerganov merged commit 2944cb7 into ggerganov:master Oct 4, 2024
44 checks passed
lyapple2008 pushed a commit to lyapple2008/whisper.cpp.mars that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants