Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ruby binding building #2484

Merged
merged 18 commits into from
Oct 16, 2024
Merged

Fix Ruby binding building #2484

merged 18 commits into from
Oct 16, 2024

Conversation

KitaitiMakoto
Copy link
Contributor

Hello,

I improved the way of building Ruby binding.

  • C/C++ files required to build binding are updated
  • You can build gem file using Rake: rake build
  • You can run tests using Rake: rake test
  • You can run install the gem in your local machine: rake install
  • You can release the gem by rake release:rubygem_push
  • Test on CI succeeds again

Can you consider this pull request?

Thanks.

@KitaitiMakoto KitaitiMakoto mentioned this pull request Oct 15, 2024
Closed
@KitaitiMakoto KitaitiMakoto changed the title Fix Ruby binding Fix Ruby binding building Oct 15, 2024
@ggerganov ggerganov merged commit d3f7137 into ggerganov:master Oct 16, 2024
45 checks passed
@KitaitiMakoto KitaitiMakoto deleted the fix-ruby-binding branch October 17, 2024 05:46
bygreencn added a commit to bygreencn/whisper.cpp that referenced this pull request Oct 21, 2024
@bygreencn
Merge remote-tracking branch 'ggerganov/master' into fix_decoding
53acd7d 
* ggerganov/master:
  readme : update links and make commands (ggerganov#2489)
  ruby : fix bindings (ggerganov#2484)
  readme : add Vulkan notice (ggerganov#2488)
  make : fix GGML_VULKAN=1 build (ggerganov#2485)
  whisper : add dtw preset for large-v3-turbo (ggerganov#2481)
  convert : handle max_target_positions (ggerganov#2477)
  readme : update the Quick Start section (ggerganov#2475)
  whisper : add OpenVINO init with state (ggerganov#2464)
lyapple2008 pushed a commit to lyapple2008/whisper.cpp.mars that referenced this pull request Nov 2, 2024
@KitaitiMakoto
ruby : fix bindings (ggerganov#2484)
a241ea1 
* Improve Rakefile

* Remove intermediate files

* Remove unnecessary manipulations from extconf.rb

* Add README and LINCENSE to source files

* Manage ext source files using YAML file

* Use extsources.yaml to include files into gem package file

* Add git-managed source files to build dependency

* Add test task

* Download model for test if not exists

* Add test for build

* Ignore gem package directory

* Enable GitHub action for Ruby binding

* Fix model name

* Build lib file for test

* Use extension for each platform

* Use extension for each platform on testing

* Move built lib file rather than copy

* Add intermediate files to clean targets
adutilleul pushed a commit to adutilleul/whisper.cpp that referenced this pull request Nov 19, 2024
@KitaitiMakoto @adutilleul
ruby : fix bindings (ggerganov#2484)
5344f26 
* Improve Rakefile

* Remove intermediate files

* Remove unnecessary manipulations from extconf.rb

* Add README and LINCENSE to source files

* Manage ext source files using YAML file

* Use extsources.yaml to include files into gem package file

* Add git-managed source files to build dependency

* Add test task

* Download model for test if not exists

* Add test for build

* Ignore gem package directory

* Enable GitHub action for Ruby binding

* Fix model name

* Build lib file for test

* Use extension for each platform

* Use extension for each platform on testing

* Move built lib file rather than copy

* Add intermediate files to clean targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KitaitiMakoto @ggerganov