convert : fix Norway problem when parsing YAML

[ngxson]

Related to #12091 (comment)

The problem is:

- no

The YAML above will be interpreted as "yes/no", which is translated into true/false boolean value.

The fix? Do a replace no --> "no"

CC @mofosyne @compilade if you have a better solution

[ngxson]

The problem seems to be fixed on yaml 1.2 specs, but pyyaml doesn't support 1.2: yaml/pyyaml#116

[compilade]

Now this if is always true, because of the extra new line.

Maybe the extra \n should be added only when joining the lines?

diff --git a/gguf-py/gguf/metadata.py b/gguf-py/gguf/metadata.py
index 0629306bb..e807f4346 100644
--- a/gguf-py/gguf/metadata.py
+++ b/gguf-py/gguf/metadata.py
@@ -139,11 +139,10 @@ class Metadata:
                     break # End of frontmatter
                 else:
                     lines_yaml.append(line)
-            yaml_content = "\n".join(lines_yaml)
+            yaml_content = "\n".join(lines_yaml) + "\n"
 
         # Quick hack to fix the Norway problem
         # https://hitchdev.com/strictyaml/why/implicit-typing-removed/
-        yaml_content += "\n"
         yaml_content = yaml_content.replace("- no\n", "- \"no\"\n")
 
         if yaml_content:

[ngxson]

Ah yes thanks, implemented in bd40850