Prevent extractValue from blowing up on undefined #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that angucomplete-alt supports passing a `.` separated key in `image-field` (and other fields), this fix will prevent an error in the case of an undefined value.
That is, given:
```
let data = [{
// ...
id: 1,
logo: undefined,
// ...
} , {
// ...
id: 2,
logo: {
thumbnail: '/img/users/portrait.png'}
}
}]
```
and passing `image-field="logo.thumbnail" local-data="data"` to angucomplete-alt, this currently causes an error on the first item: `TypeError: Cannot read property 'thumbnail' of undefined`, and no further items are rendered in the autocomplete dropdown.
This PR just adds a check to see if the current value exists before attempting to access the property.
Came across this in the course of work, just thought I'd submit this fix for you (worked around it locally). Let me know if you need me to do more to improve the PR, but it seems fairly trivial.
Regards,
Callum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that angucomplete-alt supports passing a
.separated key inimage-field(and other fields), this fix will prevent an error in the case of an undefined value.That is, given:
and passing
image-field="logo.thumbnail" local-data="data"to angucomplete-alt, this currently causes an error on the first item:TypeError: Cannot read property 'thumbnail' of undefined, and no further items are rendered in the autocomplete dropdown.This PR just adds a check to see if the current value exists before attempting to access the property.
Came across this in the course of work, just thought I'd submit this fix for you (worked around it locally). Let me know if you need me to do more to improve the PR, but it seems fairly trivial.
Regards,
Callum