chore: add Cypress & test folders as ESLint checks (#1232)

ghiscoding · Jul 6, 2024 · 88d19c0 · 88d19c0
1 parent b342b06
commit 88d19c0
Show file tree

Hide file tree

Showing 15 changed files with 37 additions and 39 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
+.eslintcache
 node_modules
 jspm_packages
 bower_components

diff --git a/.npmignore b/.npmignore
@@ -1,6 +1,7 @@
 .chrome
 .circleci
 .env
+.eslintcache
 .github
 .idea
 .vscode

diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -43,7 +43,7 @@ export default tseslint.config(
       },
       parser: tseslint.parser,
       parserOptions: {
-        project: ['./tsconfig.json']
+        project: ['./tsconfig.json', './test/tsconfig.spec.json', './test/cypress/tsconfig.json']
       }
     },
     settings: {

diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "dev": "pnpm -r --stream --parallel dev",
     "cypress:open": "cypress open --config-file test/cypress.config.ts",
     "cypress:ci": "cypress run --config-file test/cypress.config.ts",
-    "lint": "eslint packages",
+    "lint": "eslint --cache .",
     "preview:publish": "lerna publish from-package --dry-run --yes",
     "preview:version": "lerna version --dry-run --yes",
     "test:ci": "jest --runInBand --coverage=true --ci --config ./test/jest.config.ts",
@@ -41,12 +41,14 @@
   "devDependencies": {
     "@4tw/cypress-drag-drop": "^2.2.5",
     "@aurelia/fetch-client": "^2.0.0-beta.19",
+    "@aurelia/i18n": "^2.0.0-beta.19",
     "@aurelia/platform": "^2.0.0-beta.19",
     "@aurelia/platform-browser": "^2.0.0-beta.19",
     "@formkit/tempo": "^0.1.2",
     "@jest/types": "^29.6.3",
     "@lerna-lite/cli": "^3.7.0",
     "@lerna-lite/publish": "^3.7.0",
+    "@slickgrid-universal/common": "^5.3.3",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.14.10",
     "conventional-changelog-conventionalcommits": "^7.0.2",
@@ -68,6 +70,7 @@
     "npm-run-all2": "^6.2.2",
     "pnpm": "^8.15.8",
     "rimraf": "^5.0.7",
+    "rxjs": "^7.8.1",
     "ts-jest": "^29.1.5",
     "typescript": "^5.5.3",
     "typescript-eslint": "^7.15.0"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/containerServiceStub.ts b/test/containerServiceStub.ts
@@ -1,4 +1,4 @@
-import { ContainerInstance, ContainerService } from '@slickgrid-universal/common';
+import type { ContainerInstance, ContainerService } from '@slickgrid-universal/common';
 
 export class ContainerServiceStub implements ContainerService {
   dependencies: ContainerInstance[] = [];

diff --git a/test/cypress/e2e/example13.cy.ts b/test/cypress/e2e/example13.cy.ts
@@ -68,7 +68,7 @@ describe('Example 13 - Grouping & Aggregators', () => {
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * 2}px;"].slick-group-level-2 .slick-group-toggle.collapsed`).should('have.length', 1);
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * 2}px;"].slick-group-level-2 .slick-group-title`).contains(/^% Complete: [0-9]/);
 
-      cy.get(`[style="top: ${GRID_ROW_HEIGHT * 3}px;"].slick-group-totals.slick-group-level-2 .slick-cell:nth(3)`).contains(/^Avg: [0-9]\%$/);
+      cy.get(`[style="top: ${GRID_ROW_HEIGHT * 3}px;"].slick-group-totals.slick-group-level-2 .slick-cell:nth(3)`).contains(/^Avg: [0-9]%$/);
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * 3}px;"].slick-group-totals.slick-group-level-2`)
         .find('.slick-cell:nth(3)').contains('Avg: ');
     });

diff --git a/test/cypress/e2e/example30.cy.ts b/test/cypress/e2e/example30.cy.ts
@@ -421,10 +421,10 @@ describe('Example 30  Composite Editor Modal', () => {
 
     cy.get('.btn-save')
       .click()
-      .then(() => expect(alertStub.getCall(0)).to.be.calledWith('Sorry we could not detect any changes.'))
+      .then(() => expect(alertStub.getCall(0)).to.be.calledWith('Sorry we could not detect any changes.'));
 
     cy.get('.btn-cancel')
-      .click()
+      .click();
   });
 
   it('should have the "Mass Selection" button disabled when no rows are selected', () => {

diff --git a/test/cypress/e2e/example33.cy.ts b/test/cypress/e2e/example33.cy.ts
@@ -144,7 +144,7 @@ describe('Example 33 - Regular & Custom Tooltips', () => {
     cy.get('@percentage-cell').trigger('mouseover');
 
     cy.get('.slick-custom-tooltip').should('be.visible');
-    cy.get('.slick-custom-tooltip').contains(/\d+\%$/);
+    cy.get('.slick-custom-tooltip').contains(/\d+%$/);
 
     cy.get('@percentage-cell').trigger('mouseout');
   });

diff --git a/test/cypress/e2e/example34.cy.ts b/test/cypress/e2e/example34.cy.ts
@@ -18,10 +18,10 @@ describe('Example 34 - Real-Time Trading Platform', () => {
     for (let i = 0; i < 5; i++) {
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(0)`).contains(/CAD|USD$/);
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(4)`).contains(/Buy|Sell$/);
-      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(5)`).contains(/\$\(?[0-9\.]*\)?/);
-      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(6)`).contains(/\$[0-9\.]*/);
+      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(5)`).contains(/\$\(?[0-9.]*\)?/);
+      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(6)`).contains(/\$[0-9.]*/);
       cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(7)`).contains(/\d$/);
-      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9\.]*/);
+      cy.get(`[style="top: ${GRID_ROW_HEIGHT * i}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9.]*/);
     }
   });
 
@@ -54,10 +54,10 @@ describe('Example 34 - Real-Time Trading Platform', () => {
 
     cy.get(`[style="top: ${GRID_ROW_HEIGHT * 0}px;"] > .slick-cell:nth(0) .slick-group-toggle.collapsed`).should('have.length', 1);
     cy.get(`[style="top: ${GRID_ROW_HEIGHT * 0}px;"] > .slick-cell:nth(0) .slick-group-title`).should('contain', 'Currency: CAD');
-    cy.get(`[style="top: ${GRID_ROW_HEIGHT * 1}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9\,\.]*/);
+    cy.get(`[style="top: ${GRID_ROW_HEIGHT * 1}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9,.]*/);
 
     cy.get(`[style="top: ${GRID_ROW_HEIGHT * 2}px;"] > .slick-cell:nth(0) .slick-group-toggle.collapsed`).should('have.length', 1);
     cy.get(`[style="top: ${GRID_ROW_HEIGHT * 2}px;"] > .slick-cell:nth(0) .slick-group-title`).should('contain', 'Currency: USD');
-    cy.get(`[style="top: ${GRID_ROW_HEIGHT * 3}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9\,\.]*/);
+    cy.get(`[style="top: ${GRID_ROW_HEIGHT * 3}px;"] > .slick-cell:nth(8)`).contains(/\$[0-9,.]*/);
   });
 });
diff --git a/test/cypress/plugins/index.ts b/test/cypress/plugins/index.ts
@@ -12,7 +12,6 @@
 // This function is called when a project is opened or re-opened (e.g. due to
 // the project's config changing)
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default (_on: any, _config: any) => {
   // `on` is used to hook into various events Cypress emits
   // `config` is the resolved Cypress config

diff --git a/test/jest-global-mocks.ts b/test/jest-global-mocks.ts
@@ -1,9 +1,9 @@
 const mock = () => {
-  let storage = {};
+  let storage: any = {};
   return {
-    getItem: key => key in storage ? storage[key] : null,
-    setItem: (key, value) => storage[key] = value || '',
-    removeItem: key => delete storage[key],
+    getItem: (key: string) => key in storage ? storage[key] : null,
+    setItem: (key: string, value: number | string) => storage[key] = value || '',
+    removeItem: (key: string) => delete storage[key],
     clear: () => storage = {},
   };
 };
@@ -18,7 +18,7 @@ Object.defineProperty(window, '__env', { value: { env: { backendUrl: 'mocked URL
 
 Object.defineProperty(window, 'getComputedStyle', {
   value: () => ({
-    getPropertyValue: (prop) => {
+    getPropertyValue: () => {
       return '';
     }
   })

diff --git a/test/mockSlickEvent.ts b/test/mockSlickEvent.ts
@@ -1,4 +1,4 @@
-import { Handler, SlickEvent, SlickEventData } from '@slickgrid-universal/common';
+import type { Handler, SlickEvent, SlickEventData } from '@slickgrid-universal/common';
 type MergeTypes<A, B> = { [key in keyof A]: key extends keyof B ? B[key] : A[key]; } & B;
 
 // @ts-ignore

diff --git a/test/rxjsResourceStub.ts b/test/rxjsResourceStub.ts
@@ -1,7 +1,8 @@
-import { RxJsFacade } from '@slickgrid-universal/common';
+import type { RxJsFacade } from '@slickgrid-universal/common';
 import { EMPTY, iif, isObservable, firstValueFrom, Observable, Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
+// @ts-ignore
 export class RxJsResourceStub implements RxJsFacade {
   readonly className = 'RxJsResource';
 
@@ -45,4 +46,4 @@ export class RxJsResourceStub implements RxJsFacade {
   takeUntil<T>(notifier: Observable<any>): any {
     return takeUntil<T>(notifier);
   }
-}
+}
diff --git a/test/translaterServiceStub.ts b/test/translaterServiceStub.ts
@@ -1,5 +1,5 @@
-import { TranslaterService, TranslateServiceEventName } from '@slickgrid-universal/common';
-import { I18N } from '@aurelia/i18n';
+import type { TranslaterService, TranslateServiceEventName } from '@slickgrid-universal/common';
+import type { I18N } from '@aurelia/i18n';
 
 export class TranslaterServiceStub implements TranslaterService {
   eventName = 'onLanguageChange' as TranslateServiceEventName;