Convert to PDK, add support for Puppet 8 (ready to review) #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 30, 2023 08:11
Error message (using 1.0.0): error during compilation: Parameter minute failed on Cron[puppet_agent_every_thirty]: Munging failed for value 23 in class minute: undefined method `=~' for 23:Integer (file: ./puppet-module-puppet/spec/fixtures/modules/puppet/manifests/init.pp, line: 62)
|
You can see the results of the Github actions in the PR in my fork: Phil-Friderici#5 |
Phil-Friderici
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR converts the module to PDK to allow easier testing and support for Puppet 8.
It will remove support for stringified booleans which will break backward compatiblity.