Make jsoniter a required dependency and use it for enc/dec in tapir adapters
#2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
added
the
breaking change
paulpdaniels
approved these changes
Aug 17, 2024
# Conflicts: # adapters/akka-http/src/main/scala/caliban/AkkaHttpAdapter.scala # adapters/pekko-http/src/main/scala/caliban/PekkoHttpAdapter.scala # adapters/play/src/main/scala/caliban/PlayAdapter.scala # build.sbt # interop/tapir/src/main/scala/caliban/interop/tapir/HttpInterpreter.scala
ghostdogpr
approved these changes
Sep 15, 2024
Sure will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, this is an attempt to improve/simplify UX by using jsoniter as the only JSON encoding/decoding implementation for requests/responses.
Since the users are not expected to provide custom codecs for requests/responses (in fact, most of the time they shouldn't even have to know of the existence of
GraphQLRequest/GraphQLResponse), giving them an option of providing custom codecs is highly redundant and increases complexity.With the changes in this PR, users no longer need to add a
tapir-json-*dependency, and they no longer need to add any imports where they create theHttpInterpreter. Plus, this makes it easier for us to maintain this project in the longer term, as evident by this 👇