Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

2023.9 #656

Merged
merged 25 commits into from
Oct 12, 2023
Merged

2023.9 #656

merged 25 commits into from
Oct 12, 2023

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented Sep 1, 2023 •
edited
Loading

@GRadziejewski
Copy link

GRadziejewski commented Sep 7, 2023 •
edited
Loading

Iteration nr 1.

Smoke tests on desktop

  • Browser: Ghostery Private Browser 2023.9 (6d239e7)
    OS: Windows 10 Pro 22H2 19045.3393
    GBE 8.11.1

    Checked features

    • Install fresh (no profiles and etc)
    • Update
    • Ghostery cannot work before onboarding
    • Onboarding
      Enable/Disable Ghostery
    • Enable/Disable Ad-blocking
    • Enable/Disable Anti-tracking
    • Pause Ghostery
    • Never Consent
      Trackers Preview
    • Select/Unselect any/all tracker/s
    • Sign in/out
      • Sign in and then update
        Check Sync from / into another device
        Check Ghostery Settings logs
        Check Ghostery Background logs
    • Check account settings
    • Log into Google account and open google.com
      • Try to search anything
      • Try to search something with video
    • Log into FB
      Update of the GBE
    • Other (from PR)

  • Browser: Ghostery Private Browser 2023.9 ( )
    OS: MacOS Ventura 13.5.2
    GBE 8.11.1

    Checked features

    • Install fresh (no profiles and etc)
    • Update
    • Ghostery cannot work before onboarding
    • Onboarding
      Enable/Disable Ghostery
    • Enable/Disable Ad-blocking
    • Enable/Disable Anti-tracking
    • Pause Ghostery
    • Never Consent
    • Trackers Preview
    • Select/Unselect any/all tracker/s
    • Sign in/out
      • Sign in and then update
        Check Sync from / into another device
        Check Ghostery Settings logs
        Check Ghostery Background logs
    • Check account settings
    • Log into Google account and open google.com
      • Try to search anything
      • Try to search something with video
    • Log into FB
      Update of the GBE
    • Other (from PR)

Smoke tests on mobile

Checked PRs / bugfixes

New issues

@GRadziejewski GRadziejewski self-assigned this Sep 7, 2023
@GRadziejewski
Copy link

GRadziejewski commented Sep 7, 2023 •
edited
Loading

Issue nr 1.

Description
After fresh install the language selection is no longer preselected. Onboarding is in french, everything on Ghostery Panel is in french, on the New Tab, certain sentences appear in French, while the browser menu options are displayed in English. When accessing 'about:preferences' and searching for language settings, no language is preselected. There is no option to download any language at all.

Steps to Reproduce

  1. Instal Ghostery Private Browser
  2. Look at the Onboarding

image

  1. Open a New Tab

image

  1. Open Menu

image

  1. Open about:preferences

image

Expected results
Browsers language should be pre selected after an installation / upgrade.

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@yokoffing
Better-Fox.js for 2023.9
856061c 
Some small speed improvements.
A little re-ordering.
Remove depreciated prefs
@GRadziejewski
Copy link

GRadziejewski commented Sep 8, 2023 •
edited
Loading

Issue nr 2.

Description
On the Menu/ Help there is an option to Switch to a new device, which leads directly to https://www.ghostery.com/support/

Steps to Reproduce

  1. Open Menu / Help
  2. Click on Switch to a new device

image

  1. Wait

image

Expected results
This option should be deleted

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

GRadziejewski commented Sep 11, 2023 •
edited
Loading

Issue nr 3.

Description
There are several Firefox-related options (by name) that you can find in search results. One of them is #655. Two new are related to Firefox Relay.

Steps to Reproduce

  1. Open about:preferences
  2. Search for "Firefox"

image

Expected results
This option should be deleted

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

GRadziejewski commented Sep 11, 2023 •
edited
Loading

Issue nr 4.

Description
Firefox Alpenglow theme is avaiable to be selected as a main theme.

Steps to Reproduce

  1. Open about:addons
  2. Go to Themes
  3. Select Firefox Alpenglow and enable it.

image

Expected results
This theme should not be preinstalled

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

GRadziejewski commented Sep 11, 2023 •
edited
Loading

Issue nr 5.

Description
There is a text "Turn on sync" on about:logins which suggest that there is a synchronization option available.

Steps to Reproduce

  1. Open about:logins

image

Expected results
"Turn on sync" text should be hidden.

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

GRadziejewski commented Sep 11, 2023 •
edited
Loading

Issue nr 6.

Description
On the Ghost Mode window there is a "tip/ information" about the private window which leads to https://get.ghosterybrowser.com/support/private-browsing-myths . It's visible only on MacOS.

Steps to Reproduce

  1. Open a new Ghost Mode window

image

Expected results
This tip / information should be visible also on Windows.

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

GRadziejewski commented Sep 12, 2023 •
edited
Loading

Issue nr 7.

Description
On the Ghost Mode window there is a "tip/ information" about the Private window.

Steps to Reproduce

  1. Open a new Ghost Mode window

image

Expected results
On the Ghost Mode windows there should be a "tip/ information" about the Ghost Mode instead.

Versions

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (6d239e7)
OS: MacOS Ventura 13.5.2

@GRadziejewski
Copy link

Tests for iteration nr 1 are finished.

@GRadziejewski
Copy link

Issue nr 6 is not a bug.

@chrmod chrmod marked this pull request as ready for review September 13, 2023 14:57
@chrmod chrmod requested a review from yokoffing as a code owner September 13, 2023 14:57
yokoffing
yokoffing approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@yokoffing yokoffing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GRadziejewski
Copy link

GRadziejewski commented Sep 14, 2023 •
edited
Loading

Iteration nr 2.

Smoke tests

Feature Platform Platform
X Browser: Ghostery Private Browser 2023.9 (9fbc0f2)
OS: Windows 10 Pro 22H2 19045.3393
GBE: 10.1.4		 Browser: Ghostery Private Browser 2023.9 (9fbc0f2)
OS: MacOS Ventura 13.5.2
GBE: 10.1.4
Install fresh (no profiles and etc) ✔️ ✔️
Update ✔️ ✔️
Ghostery cannot work before onboarding ✔️ ✔️
Onboarding ✔️ ✔️
Enable/Disable Ghostery 🟦 🟦
Enable/Disable Ad-blocking ✔️ ✔️
Enable/Disable Anti-tracking ✔️ ✔️
Pause Ghostery ✔️ ✔️
Never Consent ✔️ ✔️
Trackers Preview
Select/Unselect any/all tracker/s 🟦 🟦
Browser settings and menus ✔️ ✔️
  Bookmarks, History ✔️ ✔️
  Help ✔️ ✔️
Sign in/out ✔️ ✔️
  Sign in and then update ✔️ ✔️
 Check Sync from / into another device ✔️ ✔️
   Check Ghostery Settings logs ✔️ ✔️
   Check Ghostery Background logs ✔️ ✔️
Check account settings ✔️ ✔️
Log into Google account and open google.com ✔️ ✔️
  Try to search anything ✔️ ✔️
  Try to search something with video ✔️ ✔️
Log into FB ✔️ ✔️
Update of the GBE 🟦 🟦

Checked PRs / bugfixes

New issues

Tests are finished at 19:00:00 UTC 21.09.2023.

@GRadziejewski
Copy link

GRadziejewski commented Sep 21, 2023 •
edited
Loading

Issue nr 8.

Description
There is Firefox Relay related option that you can find in search results.

Steps to Reproduce

  1. Open about:preferences
  2. Search for "Firefox"

image

Expected results
This option should be deleted

Versions

Browser: Ghostery Private Browser 2023.9 (9fbc0f2)
OS: Windows 10 Pro 22H2 19045.3393

Browser: Ghostery Private Browser 2023.9 (9fbc0f2)
OS: MacOS Ventura 13.5.2

@GRadziejewski GRadziejewski mentioned this pull request Sep 26, 2023
Closed
@GRadziejewski
Copy link

GRadziejewski commented Sep 27, 2023 •
edited
Loading

Tests are finished at 13:30:00 UTC 27.09.2023.

Test results of iteration nr 3 are here: [QA] Tests of Release 2023.9

New issues:

Issue #658 is not a blocker in this case.

@GRadziejewski GRadziejewski self-requested a review September 27, 2023 18:29
@GRadziejewski GRadziejewski removed their assignment Sep 27, 2023
@chrmod chrmod merged commit 3d6c9ad into main Oct 12, 2023
@chrmod chrmod deleted the 2023.9 branch October 12, 2023 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yokoffing yokoffing yokoffing approved these changes

@GRadziejewski GRadziejewski GRadziejewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrmod @GRadziejewski @yokoffing