gtk: apply all window appearance changes in syncAppearance #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluiedev
force-pushed
the
push-oqozzwxyltut
branch
2 times, most recently
from
c8b3cc0 to
12104f4
Compare
|
Just a note that just to be extra safe I'm going to push this after the 1.1 release. |
The GTK side of appearance code is kind of a mess with several different functions all having the responsibility of interacting with each other and setting the appropriate window appearance. It should solely be the responsibility of the `syncAppearance` function to apply appearance changes, with other callbacks/functions calling it instead: much like what we already do for the macOS apprt.
Doing `versionAtLeast(0, 0, 0)` to check for the existence of libadw and `versionAtLeast(1, 4, 0)` wherever tab overviews are used gets old after a while. We consolidate all of these checks (except for one unconfirmed bugfix) into easily readable functions so that maintainers don't have to memorize which libadw version added which functionality.
pluiedev
force-pushed
the
push-oqozzwxyltut
branch
from
12104f4 to
ccf054a
Compare
On Discord I've seen a bunch of bugs now that can be fixed by calling syncAppearance more regularly and in more places, and I think it'd be great if this can be part of 1.1.1. I can move the Adwaita refactors to another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GTK side of appearance code is kind of a mess with several different functions all having the responsibility of interacting with each other and setting the appropriate window appearance. It should solely be the responsibility of the
syncAppearancefunction to apply appearance changes, with other callbacks/functions calling it instead: much like what we already do for the macOS apprt.I also took the time to refactor the libadwaita version checks since calling
versionAtLeast(0, 0, 0)does get old after a while. Now almost all checks are given human-readable names and contributors need not memorize what the relevant version checks all are.