gtk: require libadwaita #5749
Merged
gtk: require libadwaita #5749
+409
−1,163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
reviewed
Feb 14, 2025
jcollie
force-pushed
the
adwaita-forever
branch
from
a6cba43 to
0ce8d6c
Compare
This commit removes support for building without libadwaita.
jcollie
force-pushed
the
adwaita-forever
branch
from
0ce8d6c to
25c5ecf
Compare
|
OK, assuming that CI passes, I think that this is ready to merge. This is really going to f*** up most existing PRs that touch GTK code. Better to rip that bandaid off so to speak IMHO. |
|
I defer to you all. I'm ready to see it happen when you are. |
pluiedev
approved these changes
Feb 15, 2025
There was a problem hiding this comment.
Just did a quick skim and I think the diff itself looks good in terms of just removing vanilla GTK mechanisms. I think there should be more follow up PRs that clean up other stuff (e.g. renaming notebook to tab view, respecting system light/dark preferences in AdwStyleManager, etc.) but we need not do them now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for building without libadwaita. (Y'all knew that I just had this sitting in my back pocket). This will need some serious review to ensure that we haven't lost any functionality.