Fixed map preview fade-in for weathers that set BLDALPHA. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Shade weather being applied to the map preview for forest type transitions.
Fixes map preview interaction with weathers that initialize BLDALPHA.
Description
If a weather sets blend parameters in its
InitVarsorInitAllfunctions, these interfere with the map preview's fade-in. Also, because the map preview grabs the state of BLDALPHA before this happens, it doesn't properly restore the blend settings for the weather afterwards.This is only an issue for people using my lighting code or who have made other similar changes to weathers. However I can't really fix it on my end. So I just added a different way to reset the blend params after the fade-in, and made the task set them to 16, 0 until the fade-in starts, to fix these issues.
Discord contact info
merrp#0001