Set image alt attribute to empty string if media text is null or empty (

OrchardCMS#16859) --------- Co-authored-by: Mike Alhayek <[email protected]>
giannik · Oct 10, 2024 · d4e5e0d · d4e5e0d
1 parent 28de8c7
commit d4e5e0d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/OrchardCore.Modules/OrchardCore.Media/Views/MediaField.cshtml b/src/OrchardCore.Modules/OrchardCore.Media/Views/MediaField.cshtml
@@ -6,22 +6,23 @@
     var mediaTexts = Model.Field?.MediaTexts ?? Array.Empty<string>();
     var name = (Model.PartFieldDefinition.PartDefinition.Name + "-" + Model.PartFieldDefinition.Name).HtmlClassify();
 }
-@if (paths.Any())
+@if (paths.Length > 0)
 {
     <div class="field field-type-mediafield field-name-@name">
         <span class="name">@Model.PartFieldDefinition.DisplayName()</span>
         @for (int i = 0; i < paths.Length; i++)
         {
             var path = paths[i];
             var url = Orchard.AssetUrl(path);
-            var text = !string.IsNullOrEmpty(mediaTexts.ElementAtOrDefault(i)) ? mediaTexts[i] : path;
 
             if (Orchard.IsImageFile(path))
             {
-                <img src="@url" alt="@text">
+                var alt = !string.IsNullOrEmpty(mediaTexts.ElementAtOrDefault(i)) ? mediaTexts[i] : string.Empty;
+                <img src="@url" alt="@alt" />
             }
             else
             {
+                var text = !string.IsNullOrEmpty(mediaTexts.ElementAtOrDefault(i)) ? mediaTexts[i] : path;
                 <a href="@url">@text</a>
             }
         }