Migrate from docker to cri logs #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
fix-storage-path-and-switch-from-docker-to-cri-support
branch
2 times, most recently
from
984f609 to
5a739ae
Compare
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
fix-storage-path-and-switch-from-docker-to-cri-support
branch
from
5a739ae to
1ad54bc
Compare
QuentinBisson
commented
Sep 27, 2022
| @@ -447,7 +448,7 @@ data: | |||
| s3_key_format {{ printf "/ssh%s" .Values.outputs.aws.S3.s3_object_key_format }} | |||
| {{- end }} | |||
| s3_key_format_tag_delimiters .-_ | |||
| store_dir ${storage_path}/S3 | |||
| store_dir ${storage_path}/S3/ssh/sshd | |||
There was a problem hiding this comment.
Changing this otherwise the output will send all the logs in there to the same folder in the bucket :(
QuentinBisson
commented
Sep 27, 2022
| @@ -115,13 +112,10 @@ spec: | |||
| - name: var-log | |||
| hostPath: | |||
| path: /var/log | |||
| - name: var-run-fluent-bit | |||
| - name: var-tmp-fluent-bit | |||
There was a problem hiding this comment.
|
@giantswarm/team-atlas this was tested on ginger and gauss. Can you review? |
mcbenjemaa
reviewed
Sep 27, 2022
mcbenjemaa
approved these changes
Sep 28, 2022
QuentinBisson
deleted the
fix-storage-path-and-switch-from-docker-to-cri-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/23799 and giantswarm/roadmap#1399 (comment)