Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate response data tests #180

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

gilbitron
Copy link
Owner

Add tests for pagination response data

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laravel-vue-pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 0:06am

Copy link

what-the-diff bot commented Nov 10, 2023

PR Summary

  • Added protective measures in RenderlessPagination.vue
    The team has added a safeguard within the code to prevent uncertainties. Certain properties can now fall back to null, which will avoid any unexpected crashes or errors.

  • Refined rightPad calculations in RenderlessPagination.vue
    Adjustments to the calculation method have been made to how rightPad is determined. This should result in more accurate results, contributing to overall better user experience and performance.

  • New Test File RenderlessPagination.spec.mjs added
    A new test file aiming to check the breakdown and interpretation of pagination data has been introduced. Through systematic comparisons of actual and expected results, the credibility of the paginate functions can be assured, improving overall software reliability and resilience.

@gilbitron gilbitron marked this pull request as ready for review November 15, 2023 12:06
@gilbitron gilbitron merged commit 0547110 into master Nov 15, 2023
5 checks passed
@gilbitron gilbitron deleted the paginate-response-data-tests branch November 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant