Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript conversion #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SorsOps
Copy link
Contributor

@SorsOps SorsOps commented Apr 14, 2024

Changes

  • Convert to typescript
  • Replace capacitorClient propdrilling with context
  • Add types from kubernetes
  • Group widgets and event handlers together
  • Minor cleanup for props that were not used, such as showMessage on the widgets
  • Replace classnames with npm package

I will handle merge conflicts if the other PRs are approved and merged in

Replace capacitorClient propdrilling with context
Add types from kubernetes
Group widgets and event handlers together
@laszlocph
Copy link
Contributor

Typescript is a big jump. At least in my head. Please allow me some time to make up my mind about it.

@SorsOps
Copy link
Contributor Author

SorsOps commented Apr 15, 2024

No problem, I think it will be necessary for this project to attract additional contributors and for this to be considered a mature project and gain adoption. I really would like this to eclipse ArgoCD.

It did help to find some of the issues such as the non standard date parsing, the fact that some dates are being compared to numbers, and some of issues with prop passing, so I do think it has value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants