WIP: all sentry patches #211
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when looking at `logging` output.
This helps with demangling some heavily-nested types. I do see some types that have generics nested 7 levels deep or more. Some boost and std types can also lead to very deep nesting.
this can now support some extreme cases like typesystem-level linked lists. the usefulness of such might be questionable, but they *are* valid types.
|
Templated lambdas (#209) are the big piece left here I believe. |
Yes they are. The spec for those was merged into the cxx-abi, as you linked to in #209 (comment), I will look into this when I get some time, although I expect that it will take me quite some time to get done. |
|
I'll probably do another minor release before that happens, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that increasing the recursion limit actually blows the stack on macOS debug builds, however it works fine on windows at least