Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* fit context to standard context #1876

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

unlikezy
Copy link

@unlikezy unlikezy commented Apr 29, 2019

#1123 (comment)
This PR try to provide a type of solution.
I look forward to more suggestion and feedback.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #1876 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   98.69%   98.74%   +0.04%     
==========================================
  Files          40       38       -2     
  Lines        2229     2157      -72     
==========================================
- Hits         2200     2130      -70     
+ Misses         16       15       -1     
+ Partials       13       12       -1     
Impacted Files Coverage Δ
context.go 98.39% <100.00%> (-0.05%) ⬇️
gin.go 99.11% <100.00%> (-0.01%) ⬇️
tree.go 100.00% <0.00%> (ø)
debug.go 96.00% <0.00%> (ø)
binding/form.go 100.00% <0.00%> (ø)
binding/binding.go 100.00% <0.00%> (ø)
binding/form_mapping.go 100.00% <0.00%> (ø)
binding/multipart_form_mapping.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502c898...e00b80a. Read the comment docs.

@ekle
Copy link

ekle commented Aug 28, 2019

#2029 does use the http request context instead of creating a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants