refactor(GiniCaptureSDK): Refactor no results screen screen_shown eve…

…nt properties to use `AnalyticsMapper` PP-392
gini · Apr 17, 2024 · 1494909 · 1494909
1 parent 0bae068
commit 1494909
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/...aptureSDK/Sources/GiniCaptureSDK/Core/Screens/NoResult/NoResultScreenViewController.swift b/...aptureSDK/Sources/GiniCaptureSDK/Core/Screens/NoResult/NoResultScreenViewController.swift
@@ -30,19 +30,6 @@ final class NoResultScreenViewController: UIViewController {
                 return text
             }
         }
-
-        var analyticsValue: String {
-            switch self {
-            case .pdf:
-                return "pdf"
-            case .image:
-                return "image"
-            case .qrCode:
-                return "qrCode"
-            default:
-                return "unknown"
-            }
-        }
     }
 
     lazy var tableView: UITableView = {
@@ -125,8 +112,8 @@ final class NoResultScreenViewController: UIViewController {
         super.viewDidLoad()
         self.setupView()
 
-        let eventProperties = [AnalyticsProperty(key: .noResultType,
-                                                 value: type.analyticsValue)]
+        let eventProperties = [AnalyticsProperty(key: .documentType,
+                                                 value: AnalyticsMapper.documentTypeAnalytics(from: type))]
         AnalyticsManager.trackScreenShown(screenName: .noResults,
                                           properties: eventProperties)
     }

diff --git a/...iniCaptureSDK/Core/Screens/Screen API Coordinator/GiniScreenAPICoordinator+Analysis.swift b/...iniCaptureSDK/Core/Screens/Screen API Coordinator/GiniScreenAPICoordinator+Analysis.swift
@@ -140,8 +140,7 @@ extension GiniScreenAPICoordinator: AnalysisDelegate {
         let viewController = ErrorScreenViewController(giniConfiguration: giniConfiguration,
                                                        type: errorType,
                                                        documentType: pages.type ?? .pdf,
-                                                       viewModel: viewModel, 
-                                                       errorAnalytics: ErrorAnalytics(type: ""))
+                                                       viewModel: viewModel)
 
         screenAPINavigationController.pushViewController(viewController, animated: animated)
     }