fix(GiniBankSDK): more PR comment fixes

gini · Jan 22, 2025 · 426893d · 426893d
1 parent 2cf8166
commit 426893d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/...APILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift b/...APILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift
@@ -7,12 +7,6 @@
 
 import Foundation
 
-/**
-Sets the default error logger. It is only used when giniErrorLoggerIsOn is true.
-- note: Internal usage only.
-**/
-var _GINIBANKAPILIBRARY_DISABLE_KEYCHAIN_PRECONDITION_FAILURE: Bool = false
-
 /// The Gini Bank API Library
 public final class GiniBankAPI {
 
@@ -151,10 +145,8 @@ extension GiniBankAPI {
                                                                    value: client.domain,
                                                                    service: .auth))
             } catch {
-                if !_GINIBANKAPILIBRARY_DISABLE_KEYCHAIN_PRECONDITION_FAILURE {
-                    preconditionFailure("There was an error using the Keychain. " +
-                                        "Check that the Keychain capability is enabled in your project")
-                }
+                preconditionFailure("There was an error using the Keychain. " +
+                                    "Check that the Keychain capability is enabled in your project")
             }
         }
     }

diff --git a/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift b/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift
@@ -9,6 +9,8 @@
 @testable import GiniCaptureSDK
 import XCTest
 
+var _GINIBANKAPILIBRARY_DISABLE_KEYCHAIN_PRECONDITION_FAILURE: Bool = false
+
 private class MockTokenSource: AlternativeTokenSource {
     var token: Token?
     init(token: Token? = nil) {
@@ -28,7 +30,7 @@ private class MockCaptureResultsDelegate: GiniCaptureResultsDelegate {
     func giniCaptureAnalysisDidFinishWith(result: AnalysisResult) {
     }
 
-    func giniCaptureDidCloseAnalysis() {
+    func giniCaptureDidCancelAnalysis() {
         closeCalled = true
     }