Merge pull request #473 from gini/IPC-194-GiniHealthSDK-UnitTests

feat(GiniHealthSDK): UnitTests for GiniHealthSDK IPC-196

BankSDK/GiniBankSDKPinningExample/Tests/Resources/result_Gini_invoice_example.json

@@ -155,4 +155,4 @@
       }
     ]
   }
-}
+}

HealthAPILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Core/GiniHealthAPI.swift

@@ -10,8 +10,8 @@ import Foundation
 /// The Gini Health API Library
 public final class GiniHealthAPI {
 
-    private let docService: DocumentService!
-    private let payService: PaymentService?
+    private var docService: DocumentService!
+    private var payService: PaymentService?
     static var logLevel: LogLevel = .none
     public var sessionDelegate: URLSessionDelegate? = nil
 

HealthAPILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Document.swift

@@ -271,3 +271,9 @@ extension Document.Links: Decodable {
 extension Document.Layout: Decodable {
 
 }
+
+extension Document: Equatable {
+    public static func == (lhs: Document, rhs: Document) -> Bool {
+        lhs.id == rhs.id
+    }    
+}

HealthAPILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/ExtractionsContainer.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-struct ExtractionsContainer {
+public struct ExtractionsContainer {
     let extractions: [Extraction]
     let compoundExtractions: [String : [[Extraction]]]?
     let candidates: [Extraction.Candidate]
@@ -23,7 +23,7 @@ struct ExtractionsContainer {
 
 extension ExtractionsContainer: Decodable {
 
-    init(from decoder: Decoder) throws {
+    public init(from decoder: Decoder) throws {
         let container = try decoder.container(keyedBy: CodingKeys.self)
 
         let decodedExtractions = try container.decode([String : Extraction].self,

HealthAPILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Payments/PaymentProvider.swift

@@ -14,7 +14,7 @@ public struct PaymentProvider: Codable {
     public var name: String
     public var appSchemeIOS: String
     public var colors: ProviderColors
-    var minAppVersion: MinAppVersions?
+    public var minAppVersion: MinAppVersions?
     public var iconData: Data
     public var appStoreUrlIOS: String?
     public var universalLinkIOS: String
@@ -31,3 +31,9 @@ public struct PaymentProvider: Codable {
     }
 }
 public typealias PaymentProviders = [PaymentProvider]
+
+extension PaymentProvider: Equatable {
+    public static func == (lhs: PaymentProvider, rhs: PaymentProvider) -> Bool {
+        lhs.id == rhs.id
+    }
+}

HealthAPILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Payments/PaymentProviderResponse.swift

@@ -38,7 +38,7 @@ public struct PaymentProviderResponse: Codable {
     public var name: String
     public var appSchemeIOS: String
     public var colors: ProviderColors
-    var minAppVersion: MinAppVersions?
+    public var minAppVersion: MinAppVersions?
     public var iconLocation: String
     public var appStoreUrlIOS: String?
     public var universalLinkIOS: String

HealthSDK/GiniHealthSDK/Package.swift

@@ -27,6 +27,9 @@ let package = Package(
             dependencies: ["GiniHealthAPILibrary"]),
         .testTarget(
             name: "GiniHealthSDKTests",
-            dependencies: ["GiniHealthSDK"]),
+            dependencies: ["GiniHealthSDK"],
+            resources: [
+                .process("Resources")
+            ]),
     ]
 )

HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift

@@ -41,6 +41,8 @@ public enum GiniHealthError: Error {
     /// Error thrown when api didn't returns payment extractions.
     case noPaymentDataExtracted
 }
+
+extension GiniHealthError: Equatable {}
 /**
  Data structure for Payment Review Screen initialization.
  */
@@ -169,7 +171,9 @@ public struct DataForReview {
                         switch result {
                         case let .success(extractionResult):
                             if let paymentExtractions = extractionResult.payment?.first, let iban = paymentExtractions.first(where: { $0.name == "iban" })?.value, !iban.isEmpty {
-                            completion(.success(true))
+                                completion(.success(true))
+                            } else if let ibanExtraction = extractionResult.extractions.first(where: { $0.name == "iban"})?.value, !ibanExtraction.isEmpty {
+                                completion(.success(true))
                             } else {
                                 completion(.success(false))
                             }
@@ -220,32 +224,32 @@ public struct DataForReview {
 
      */
     public func getExtractions(docId: String, completion: @escaping (Result<[Extraction], GiniHealthError>) -> Void){
-            documentService.fetchDocument(with: docId) { result in
-                switch result {
-                case let .success(createdDocument):
-                    self.documentService
-                            .extractions(for: createdDocument,
-                                         cancellationToken: CancellationToken()) { result in
-                                DispatchQueue.main.async {
-                                    switch result {
-                                    case let .success(extractionResult):
-                                        if let paymentExtractionsContainer = extractionResult.payment, let paymentExtractions = paymentExtractionsContainer.first {
-                                            completion(.success(paymentExtractions))
-                                        } else {
-                                            completion(.failure(.noPaymentDataExtracted))
-                                        }
-                                    case let .failure(error):
-                                        completion(.failure(.apiError(error)))
+        documentService.fetchDocument(with: docId) { result in
+            switch result {
+            case let .success(createdDocument):
+                self.documentService
+                        .extractions(for: createdDocument,
+                                     cancellationToken: CancellationToken()) { result in
+                            DispatchQueue.main.async {
+                                switch result {
+                                case let .success(extractionResult):
+                                    if let paymentExtractionsContainer = extractionResult.payment, let paymentExtractions = paymentExtractionsContainer.first {
+                                        completion(.success(paymentExtractions))
+                                    } else {
+                                        completion(.failure(.noPaymentDataExtracted))
                                     }
+                                case let .failure(error):
+                                    completion(.failure(.apiError(error)))
                                 }
                             }
-                case let .failure(error):
-                    DispatchQueue.main.async {
-                        completion(.failure(.apiError(error)))
-                    }
+                        }
+            case let .failure(error):
+                DispatchQueue.main.async {
+                    completion(.failure(.apiError(error)))
                 }
             }
         }
+    }
 
     /**
      Creates a payment request
@@ -279,16 +283,15 @@ public struct DataForReview {
      - Parameters:
         - requestID: Id of the created payment request.
         - universalLink: Universal link for the selected payment provider
-
      */
-    public func openPaymentProviderApp(requestID: String, universalLink: String) {
+    public func openPaymentProviderApp(requestID: String, universalLink: String, urlOpener: URLOpener = URLOpener(UIApplication.shared), completion: ((Bool) -> Void)? = nil) {
         let queryItems = [URLQueryItem(name: "id", value: requestID)]
         let urlString = universalLink + "://payment"
         var urlComponents = URLComponents(string: urlString)!
         urlComponents.queryItems = queryItems
         let resultUrl = urlComponents.url!
         DispatchQueue.main.async {
-            UIApplication.shared.open(resultUrl, options: [:], completionHandler: nil)
+            urlOpener.openLink(url: resultUrl, completion: completion)
         }
     }
 
@@ -365,3 +368,4 @@ public struct DataForReview {
         }
     }
 }
+

HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift

@@ -16,10 +16,21 @@ public protocol PaymentComponentsControllerProtocol: AnyObject {
     func didFetchedPaymentProviders()
 }
 
+protocol PaymentComponentsProtocol {
+    var isLoading: Bool { get set }
+    var selectedPaymentProvider: PaymentProvider? { get set }
+    func loadPaymentProviders()
+    func checkIfDocumentIsPayable(docId: String, completion: @escaping (Result<Bool, GiniHealthError>) -> Void)
+    func paymentView(documentId: String) -> UIView
+    func bankSelectionBottomSheet() -> UIViewController
+    func loadPaymentReviewScreenFor(documentID: String, trackingDelegate: GiniHealthTrackingDelegate?, completion: @escaping (UIViewController?, GiniHealthError?) -> Void)
+    func paymentInfoViewController() -> UIViewController
+}
+
 /**
  The `PaymentComponentsController` class allows control over the payment components.
  */
-public final class PaymentComponentsController: NSObject {
+public final class PaymentComponentsController: PaymentComponentsProtocol {
     /// handling the Payment Component Controller delegate
     public weak var delegate: PaymentComponentsControllerProtocol?
     /// handling the Payment Component view delegate
@@ -53,7 +64,6 @@ public final class PaymentComponentsController: NSObject {
      */
     public init(giniHealth: GiniHealth) {
         self.giniHealth = giniHealth
-        super.init()
         setupListeners()
     }
 

HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/URLOpener.swift

@@ -0,0 +1,39 @@
+//
+//  URLOpener.swift
+//
+//  Copyright © 2024 Gini GmbH. All rights reserved.
+//
+
+import UIKit
+
+// URLOpener helper structure for better testing of the open AppStore links functionality
+public struct URLOpener {
+    private let application: URLOpenerProtocol
+
+    public init(_ application: URLOpenerProtocol) {
+        self.application = application
+    }
+
+    /// Opens AppStore with the provided URL
+    ///
+    /// - Parameters:
+    ///   - url: link that will be opened
+    ///   - completion: called after opening is completed
+    ///                 param is true if website was opened successfully
+    ///                 param is false if opening failed
+
+    func openLink(url: URL, completion: ((Bool) -> Void)?) {
+        if application.canOpenURL(url) {
+            application.open(url, options: [:], completionHandler: completion)
+        } else {
+            completion?(false)
+        }
+    }
+}
+
+public protocol URLOpenerProtocol {
+    func canOpenURL(_ url: URL) -> Bool
+    func open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey : Any], completionHandler completion: ((Bool) -> Void)?)
+}
+
+extension UIApplication: URLOpenerProtocol {}