Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bsdk 35 create fastlane lane to generate release podspecs with the release version #450

Merged
merged 20 commits into from
Feb 9, 2024
Merged

Bsdk 35 create fastlane lane to generate release podspecs with the release version #450

merged 20 commits into from
Feb 9, 2024

Conversation

ValentinaIancu-Gini
Copy link
Contributor

@ValentinaIancu-Gini ValentinaIancu-Gini commented Jan 24, 2024 •
edited
Loading

  • add a Readme file with manual steps for how to release a new version of podspecs in gini-podspecs
  • add an example of podspecs file
  • create a Fastlane lane to generate release podspecs with the release version

Steps to test this locally:

  • add the folder with the needed frameworks for GiniBankSDK(GiniBankSDK, GiniBankApiLibrary, and GiniCaptureSDK) in the recently added folder Pod which can be found in the GiniBankSDK folder from BankSDK from the main folder of the project
  • locate the local path for this folder from your computer
  • locate the local path for the gini-podspecs repo from your computer
  • pod_name: name of the podspecs file
  • template_podspec_path : path to the template podspec file from the local clone of the mono repo project, which is modified and used for the new pod version e.g: BankSDK/GiniBankSDK/Pod/GiniBankSDK.podspec
  • go to the terminal and navigate to the main folder of the gini-mobile-ios repo
  • run this command
fastlane publish_podspec xcframeworks_folder_path:</path/to/xcframeworks> pod_name:<Name> podspecs_repo_sdk_folder_path:</path/to/gini-podspecs> template_podspec_path:</path/to/Pod/<Pod_Name.podspec>

and replace all the paths.

Example:

fastlane publish_podspec xcframeworks_folder_path:/Users/valentinaiancu/Documents/Workspace/gini-mobile-ios/BankSDK/GiniBankSDK/Pod/GiniBankSDKPinning_3.7.2_XCFrameworks pod_name:GiniBankSDK podspecs_repo_sdk_folder_path:/Users/valentinaiancu/Documents/Workspace/gini-podspecs/GiniBankSDK template_podspec_path:/Users/valentinaiancu/Documents/Workspace/gini-mobile-ios/BankSDK/GiniBankSDK/Pod/GiniBankSDK.podspec

@ValentinaIancu-Gini
ci(GiniBankSDK): Add Readme file with steps to release a new versio…
4236610 
…n of `gini-podspecs`

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Add example of GiniBankSDK.podspec
53ce977 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Add new lane generate_release_podspecs with parame…
2022cd2 
…ters in Fastfile

- added new lane to automatically create, commit and push new a folder version for GiniBankSDK in `gini-podspecs` repo with the new `podspec` file and frameworks archived

BSDK-35
@ValentinaIancu-Gini ValentinaIancu-Gini self-assigned this Jan 24, 2024
@ValentinaIancu-Gini
ci(GiniBankSDKPinning): Add Readme file with steps to release a new…
5fbc90e 
… version of `gini-podspecs`

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDKPinning): Add example of GiniBankSDKPinning.podspec
3224671 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDKPinning): Modify generate_release_podspecs lane to be…
05bee04 
… used for every SDK

- `podspec_name` parameter added to the `generate_release_podspecs` lane in order to be used to generate podspecs for whatever SDK is needed

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Add description for generate_release_podspecs lane…
0432004 
… in the fastlane README file

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Update spec.version and copy write year in `GiniBa…
33cd360 
…nkSDKPinning.podspec` file

BSDK-35
a-szotyori
a-szotyori suggested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small refactoring is needed to match the style of the existing lanes better and to reuse existing utility code.

fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
@ValentinaIancu-Gini
ci(GiniBankSDK): List and describe the parameters in the description …
b370a4f 
…of the new lane `generate_release_podspecs`

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Rename lane into publish_podspec
dcf8afb 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Use `get_latest_version_from_release_tags(podspec_na…
da816d8 
…me, UI)` from `versions.rb`

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Use tuple check_and_get_options(options,[], UI)
9c0854c 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Rename podspec_name into pod_name
3cc2a5d 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Pass the path of the template .podspec file as a l…
0ee225e 
…ane parameter

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Improve confirmation message to push the changes to …
bd14a50 
…`gini-podspecs` repo

BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Update Fastlane README.md file
4fd00dc 
BSDK-35
@ValentinaIancu-Gini
ci(GiniBankSDK): Remove "Pinning" suffix from pod_name, if needed, …
b85e873 
…when extracting the last version of the release tag

BSDK-35
zladzeyka
zladzeyka approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tested XCFrameworks generation yesterday together with @ValentinaIancu-Gini 👏🏻
Tiny suggestion: to use the latest released SDK version number in podspecs

BankSDK/GiniBankSDKPinning/Pod/GiniBankSDKPinning.podspec Outdated Show resolved Hide resolved
BankSDK/GiniBankSDKPinning/Pod/GiniBankSDKPinning.podspec Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
BankSDK/GiniBankSDKPinning/Pod/GiniBankSDKPinning.podspec Outdated Show resolved Hide resolved
BankSDK/GiniBankSDK/Pod/GiniBankSDK.podspec Outdated Show resolved Hide resolved
@ValentinaIancu-Gini
Copy link
Contributor Author

@a-szotyori is this good to be merged? Thanks!

a-szotyori
a-szotyori approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I only saw an unused variable. I don't want to reject the PR due to that, but it would be nice to remove it before merging 😉 .

fastlane/Fastfile Outdated Show resolved Hide resolved
@ValentinaIancu-Gini ValentinaIancu-Gini merged commit 2f2df21 into main Feb 9, 2024
5 checks passed
@ValentinaIancu-Gini ValentinaIancu-Gini deleted the BSDK-35-Create-fastlane-lane-to-generate-release-podspecs-with-the-release-version branch February 9, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zladzeyka zladzeyka zladzeyka approved these changes

@a-szotyori a-szotyori a-szotyori approved these changes

Assignees

@ValentinaIancu-Gini ValentinaIancu-Gini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentinaIancu-Gini @zladzeyka @a-szotyori