feat(GiniHealthSDK): Payment providers added to payment component IPC-97 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvancapra
requested review from
zladzeyka,
a-szotyori and
ValentinaIancu-Gini
… with info till viewcontroller IPC-97
… to one place IPC-97
zladzeyka
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Thank you @razvancapra, great job!👏🏻
There are some small comments and I would like to ask to sort out the extensions. Let's keep the extensions folder and move the existing there as well
I think you UIColorextension can be moved in UIColor + Utils and etc.
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentView.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentView.swift
Outdated
Show resolved
Hide resolved
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
…ders async on Payment Controller IPC-97
…ent-component-bank-available
|
Thank you @razvancapra for your great work! I took the liberty to test on my favourite device 🙈 : iPhone SE first generation with iOS 15.5(simulator) and I saw that the name of the provider did not fit in the label. Please see the image attached. Also in dark mode, the dropdown arrow is not very visible:
|
…ent-component-bank-available
|
@razvancapra thanks for fixing those UI issues. Now is looking good both on dark mode and on that small device! Great job! |
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/AppCoordinator.swift
Show resolved
Hide resolved
…ent-component-bank-available
+ Obtain all payment providers for bottom sheet IPC-110
… buttons review request from Nadya IPC-97
Base automatically changed from
payment-component-pay-invoice-button
to
ipc-health-sdk-update
February 22, 2024 09:25
zladzeyka
reviewed
Feb 22, 2024
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/UIColor+Utils.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealthConfiguration.swift
Outdated
Show resolved
Hide resolved
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
...DK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentViewModel.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/InvoicesList/InvoicesListViewModel.swift
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentPrimaryButton.swift
Show resolved
Hide resolved
…olour, updates `poweredby` string IPC-97
- naming, renaming and adding comments parameter to texts IPC-97
…er isn't installed IPC-97
zladzeyka
approved these changes
Feb 23, 2024
…ller + handle deletion of bank flow IPC-97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: https://ginis.atlassian.net/browse/IPC-97