feat(GiniHealthSDK): Payment component bottom sheet IPC-99 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ additional fixes IPC-99
…k_selection_bottom_sheet
…com/gini/gini-mobile-ios into IPC-136_bank_selection_bottom_sheet
+ payment bottom sheet fixes IPC-99
…s to foreground IPC-99
…k_selection_bottom_sheet
…k_selection_bottom_sheet
… closing bottom sheet IPC-99
…rom bottom list IPC-99
used the official guidelines: https://developer.apple.com/app-store/marketing/guidelines/ IPC-99
…pStore url IPC-99
…k_selection_bottom_sheet
…k_selection_bottom_sheet
…althSDKExample app IPC-36
…k_selection_bottom_sheet
razvancapra
requested review from
zladzeyka,
a-szotyori and
ValentinaIancu-Gini
fix the loading payment providers tests IPC-99
zladzeyka
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Great job @razvancapra
I left the comments mostly about renaming.
When we retrieve the saved payment provider we need to check if this payment provider still among the providers that we retrieve from the server, do we do that?
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
...althSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentProviderBottomTableViewCell.swift
Outdated
Show resolved
Hide resolved
...es.xcassets/appStoreIcon.imageset/Download_on_the_App_Store_Badge_US-UK_RGB_blk_092917 2.svg
Outdated
Show resolved
Hide resolved
...iImages.xcassets/appStoreIcon.imageset/Download_on_the_App_Store_Badge_DE_RGB_blk_092917.svg
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift
Outdated
Show resolved
Hide resolved
...thSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentProvidersBottomViewController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/InvoicesList/InvoicesListViewModel.swift
Outdated
Show resolved
Hide resolved
|
UI changes are needed: |
…der to bank IPC-99
…ayment providers supported IPC-99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPC-99