feat(GiniHealthSDK): Pay invoice to new payment review screen IPC-133 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ContainerBackgroundColor from the pallette IPC-153, IPC-159
…m the configuration for text field, pay button disable state, page indicator; Adds Success colours to the palette IPC-153
…nfiguration options, removes customFont configuration option - adds fallbacks for the default font, removes outdated options from the example app IPC-153
…_screen * IPC-156-pay-invoice-button: (39 commits) fix(GiniHealthSDKExample): Fix error message after clean fix(GiniHealthSDK): Replace AppStore svg icons with pdf icons fix(GiniHealthSDK): Check if store payment provider is still amoung payment providers supported fix(GiniHealthSDK): Fix bank icon border and corners radius on bottom sheet fix(GiniHealthSDK): Fix payment provider to bank renaming fix(GiniHealthSDK): Renaming of classes and methods from paymentProvider to bank fix(GiniHealthSDK): Fix selecting new bank flow feat(GiniHealthSDK): Link pay invoice with Payment Review ViewController fx(GiniHealthAPILibrary): Fix Request tests fix(GiniHealthSDK): Fix private function + adding comments fix(GiniHealthSDK): Fix bottom sheet corners on smaller devices fix(GiniHealthSDK): Fix bottom sheet appearance when no bank installed fix(GiniHealthSDK): Fix integration guide after deleting stored payment provider fix(GiniHealthSDK): Store selected payment provider in payment controller + handle deletion of bank flow fix(GiniHealthSDK): Remove stored paymentProvider in invoice object feat(GiniHealthSDK): Payment review view controller new instantiate fix(GiniHealthSDKexmaple): Adds Queried URL Schemes fix(GiniHealthSDK): Fix GiniHealthColors renaming feat(GiniHealthSDKExample): Add new queries schemes handled by GiniHealthSDKExample app fix(GiniHealthSDK): Fix integration guide documentation ... # Conflicts: # HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealthConfiguration.swift
…nts in PaymentComponent IPC-153
…extFields views with labels IPC-153
…ws directly The documentIds are passed back to the client via the viewDelegate (PaymentComponentViewProtocol) on the PaymentComponentsController. This allows clients to set the documentId once for each Payment Component View and then receive the respective documentId back to know which Payment Component View was triggered. IPC-153
zladzeyka
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Great job 👏🏻 @razvancapra
Please find a few small comments:
Could you please cleanup our Payment Review Screen, I didn't refactor for a long time and move out the constants in the enum?
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentReviewViewController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentReviewViewController.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDKExample/GiniHealthSDKExample/InvoicesList/InvoicesListViewModel.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/UITextField+Utils.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
zladzeyka
approved these changes
Mar 11, 2024
…t bank picker IPC-203
…flows We added the first payment provider to both flows IPC-203
|
@zladzeyka addded the info bar fix here as well because is a minor fix: |
- Added new flows logic to GiniHealthSDKExample app IPC-166
Fix minor warnings IPC-154
…153_payment_review_screen
zladzeyka
approved these changes
Mar 19, 2024
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Resources/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Resources/en.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
zladzeyka
reviewed
Mar 19, 2024
Base automatically changed from
IPC-162-more-information-screen
to
ipc-health-sdk-update
March 19, 2024 12:27
zladzeyka
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPC-133
IPC-153
IPC-81
IPC-167
IPC-206
https://ginis.atlassian.net/browse/IPC-133
https://ginis.atlassian.net/browse/IPC-153
https://ginis.atlassian.net/browse/IPC-81
https://ginis.atlassian.net/browse/IPC-167
https://ginis.atlassian.net/browse/IPC-206